Skip to content

chore(githooks): add ui package and terminal styling - #23616

Open
kalverra wants to merge 1 commit into
developfrom
DX-5066/1-ui-styling
Open

chore(githooks): add ui package and terminal styling#23616
kalverra wants to merge 1 commit into
developfrom
DX-5066/1-ui-styling

Conversation

@kalverra

@kalverra kalverra commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Intent

Introduce a centralized terminal UI styling package and color support to tools/githooks for clearer hook feedback, status badges, and non-intrusive error reporting.

Changes

  • Add internal/ui package: Provides unified terminal styling, color detection (NO_COLOR support), and reusable status badges ([ OK ], [ WARN ], [ LARGE ], [LINT], [TEST]) powered by Lip Gloss.
  • Add --no-color persistent flag: Allows disabling ANSI escape codes in CI environments or by user preference.
  • Introduce SilentError: Allows commands that have already rendered formatted diagnostic boxes to exit with code 1 without duplicate Error: ... printouts in main.go.
  • Update existing commands (lint, test, eof, whitespace, tidy): Switch from unstructured text to clear badge headers and formatted runners.
  • Clean up benchmark tests: Fix linter warnings in benchmark helper signatures and remove stale tests.

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting develop

@cl-sonarqube-production

Copy link
Copy Markdown

@kalverra
kalverra marked this pull request as ready for review September 1, 2026 20:13
@kalverra
kalverra requested review from a team as code owners September 1, 2026 20:13
@kalverra
kalverra requested a review from paigeCLL September 1, 2026 20:14

@paigeCLL paigeCLL left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to hold off on these changes to drive alignment with the broader org on the content and the Eng Data AI team on how we approach standardization of AI instructions in our code bases.

@trunk-io

trunk-io Bot commented Sep 1, 2026

Copy link
Copy Markdown

Static BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants