Skip to content

[Config Consolidation] Refactor ocr2 delegate - #23565

Open
vyzaldysanchez wants to merge 4 commits into
task/CRE-1775/simplify-job-specfrom
task/CRE-1786/refactor-delegate
Open

[Config Consolidation] Refactor ocr2 delegate#23565
vyzaldysanchez wants to merge 4 commits into
task/CRE-1775/simplify-job-specfrom
task/CRE-1786/refactor-delegate

Conversation

@vyzaldysanchez

Copy link
Copy Markdown
Contributor

Requires

Supports

@github-actions

github-actions Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

CORA - Analysis Skipped

Reason: The number of code owners (2) is less than the minimum required (5) and/or the number of CODEOWNERS entries with changed files (2) is less than the minimum required (2).

@github-actions

github-actions Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting task/CRE-1775/simplify-job-spec

@github-actions

Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@trunk-io

trunk-io Bot commented Aug 27, 2026

Copy link
Copy Markdown

Static BadgeStatic BadgeStatic Badge

Failed Test Failure Summary Logs
Test_CRE_V2_Suite_Bucket_B/Vault_DON_-_mixed-env/allowlist_auth_when_jwt_auth_disabled The test failed during execution without providing specific error details. Logs ↗︎
Test_CRE_V2_Suite_Bucket_B/Vault_DON_-_mixed-env/allowlist_auth_when_jwt_auth_disabled/allowlist_update_batch_at_limit The test failed during an Ethereum smart contract allowlist operation, indicating an issue with the allowlist request or transaction processing. Logs ↗︎
Test_CRE_V2_Suite_Bucket_B/Vault_DON_-_mixed-env The test failed during a blockchain environment setup, likely due to an error in transaction processing or environment configuration. Logs ↗︎
Test_CRE_V2_Suite_Bucket_B/Vault_DON_-_mixed-env/jwt_auth_rejected_when_jwt_auth_disabled/jwt_without_workflow_owner_rejected_wh... The test failed because the expected HTTP response status code did not match the actual, which was a timeout leading to a 503 error instead of the... Logs ↗︎

... and 5 more

View Full Report ↗︎Docs

@vyzaldysanchez
vyzaldysanchez changed the base branch from develop to task/CRE-1775/simplify-job-spec August 27, 2026 18:42
@bolekk bolekk changed the title [Config Consolidation] Refactor delegate [Config Consolidation] Refactor ocr2 delegate Sep 1, 2026

@bolekk bolekk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall

Comment thread core/services/cre/cre.go Outdated
)

// dontimeCapabilityID is the registry capability ID for DONTime.
const dontimeCapabilityID = "dontime@1.0.0"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's be careful and match the prefix "dontime" in case the version changes in the future.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter says this is unused?

@vyzaldysanchez
vyzaldysanchez marked this pull request as ready for review September 1, 2026 13:59
@vyzaldysanchez
vyzaldysanchez requested review from a team as code owners September 1, 2026 13:59
@cl-sonarqube-production

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants