[NONEVM-2925] Notify Sender #301
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patricios-space
force-pushed
the
feat/notify-sender
branch
4 times, most recently
from
45a2bcc to
42798d1
Compare
patricios-space
force-pushed
the
feat/notify-sender
branch
from
283ce70 to
a5e9349
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR implements sender notification functionality for CCIP message routing, allowing the router to notify senders about the success or failure of their CCIP send operations via acknowledgment (ACK) or negative acknowledgment (NACK) messages.
Key changes:
- Added new message types
MessageSent,MessageRejected,CCIPSendACK, andCCIPSendNACKfor sender notifications - Implemented error handling path with
ExecutorFinishedWithErrorandMessageValidationFailedmessages - Updated the OnRamp to notify the Router upon successful or failed message processing, which then notifies the original sender
Reviewed Changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/ccip/bindings/router/router.go | Added router message structures for sender notifications (MessageSent, MessageRejected, CCIPSendACK, CCIPSendNACK) |
| pkg/ccip/bindings/onramp/onramp.go | Added ExecutorFinishedWithError message type for error handling |
| pkg/ccip/bindings/feequoter/fee_quoter.go | Removed MessageValidated opcode (moved to executor) |
| pkg/ccip/bindings/ccipsendexecutor/ccipsendexecutor.go | Added MessageValidated and MessageValidationFailed message types |
| pkg/ton/debug/decoders/ccip/router/router.go | Added decoder support for new router message types |
| pkg/ton/debug/decoders/ccip/feequoter/feequoter.go | Removed MessageValidated decoder (moved to executor) |
| pkg/ton/debug/decoders/ccip/ccipsendexecutor/ccipsendexecutor.go | Added decoders for executor validation messages |
| contracts/wrappers/ccip/Router.ts | Added TypeScript wrappers and codecs for new message types |
| contracts/wrappers/ccip/OnRamp.ts | Added wrapper methods for executor finish messages and updated opcode |
| contracts/wrappers/ccip/FeeQuoter.ts | Added opcodes for validation messages |
| contracts/contracts/ccip/router/contract.tolk | Implemented onSendACK and onSendNACK handlers |
| contracts/contracts/ccip/onramp/contract.tolk | Implemented replyWithError handler and sender notification logic |
| contracts/contracts/ccip/fee_quoter/contract.tolk | Added try-catch for fee validation with error response |
| contracts/contracts/ccip/ccipsend_executor/contract.tolk | Implemented validation failure handling and error exit logic |
| contracts/tests/ccip/CCIPRouter.spec.ts | Added tests for sender notifications and balance management |
| docs/contracts/ccip/flow/onramp/*.md | Updated documentation to reflect new message names |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
patricios-space
force-pushed
the
feat/notify-sender
branch
from
a400465 to
a5e9349
Compare
patricios-space
commented
Nov 4, 2025
Comment on lines
+139
to
143
| // if (msg.fee > self.originalBalance) { | ||
| // self.exitWithError(CCIPSendExecutor_Error.InsufficientFunds as int, sender); | ||
| // return; | ||
| // } | ||
|
|
There was a problem hiding this comment.
This will be address in a different PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NONEVM-2925