[NONEVM-2076] Verify FeeQuoter math and units #296
+9,860
−644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patricios-space
force-pushed
the
test/feequoter
branch
from
b123ba2 to
31dbc93
Compare
archseer
reviewed
Oct 31, 2025
| @@ -0,0 +1,56 @@ | |||
| import Decimal from 'decimal.js' | |||
There was a problem hiding this comment.
Do we really need this? It should be enough to use bigints then only use the decimals setting when formatting the value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NONEVM-2076
Validate the fee quoter calculations are correct (decimal points etc. similar to solana we might have to scale down to 9 decimals rather than 18)
Validate the integer sizing for all types (again based on Solana we might be able to size some types down)
Write unit test on FeeQuoter covering this