Fix ton accessor GetFeeQuoterTokenUpdates #295

huangzhen1997 · 2025-10-31T01:25:13Z

https://chainlink-core.slack.com/archives/C08KVCWAZUG/p1761855754149519

Copilot

Pull Request Overview

This PR refactors the GetFeeQuoterTokenUpdates method in the TON accessor to fix how token price data is fetched. Instead of calling a batch tokenPrices method, it now fetches token prices individually using the tokenPrice getter method with the new FetchResult helper.

Key changes:

Replaced batch token price fetching with individual per-token calls using FetchResult
Added FetchResult helper method to TimestampedPrice struct with a new tokenPriceGetter constant
Added integration test coverage for the token price fetching functionality

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
pkg/ccip/chainaccessor/ton_accessor.go	Refactored `GetFeeQuoterTokenUpdates` to fetch prices individually instead of in batch
pkg/ccip/bindings/feequoter/fee_quoter.go	Added `FetchResult` helper method and `tokenPriceGetter` constant to support individual token price fetching
integration-tests/deployment/cs_test.go	Added test case for fetching token prices and fixed import ordering

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-10-31T01:25:59Z

pkg/ccip/chainaccessor/ton_accessor.go

+		var tokenPrice feequoter.TimestampedPrice
+		err = tokenPrice.FetchResult(ctx, a.client, block, addr, []interface{}{cell.BeginCell().MustStoreAddr(addrParsed).EndCell().BeginParse()})


This implementation makes a separate RPC call for each token in the loop, which could cause significant performance degradation when fetching prices for multiple tokens. The original batch implementation was more efficient. Consider if this sequential approach is necessary or if batch fetching can be preserved.

This was my first reaction too from the slack discussion 🤔 Wouldn't this be a fair amount slower or cause additional strain on the endpoint? This GetFeeQuoterTokenUpdates() function can be queried pretty often

IIRC I had discuss this with @archseer at some point, that it's better to fetch individual config/price so that TVM will not allocate a huge stack space to store them as this map could become very big

For speed, yeah I'm going to add a errGroup to parallelize the loop

This was the discussion. But it was slightly different as DestChainConfig is much bigger than timestampPrice. We are less likely hit the 255 stack limit for fetching token prices, so maybe it's better to do batching if GetFeeQuoterTokenUpdates() gets called very often.

Discussed with @ogtownsend offline, only LINK and the native token are used most of the time as input tokens for GetFeeQuoterTokenUpdates, so batching is not implemented for now to keep everything simple and clean. Added a comment to mention that batching can be added later if needed.

If we are planing to merge this as-is and leave the parallelization for later, should we add a TODO here?

right now parallelization is not needed for just two tokens. if we going to support batching it would just be one rpc call

pkg/ccip/bindings/feequoter/fee_quoter.go

ogtownsend · 2025-10-31T17:12:32Z

pkg/ccip/chainaccessor/ton_accessor.go

-		case nil:
-			// return zero value
-			price = ccipocr3.TimestampedUnixBig{
-				Value:     big.NewInt(0),
-				Timestamp: 0,
-			}
-		case cell.Cell:


Do we not need to explicitly handle this case anymore?

Yes I'm adding that but I notice the contact mustGet is not retuning the right error code but returned stack underflow, checking what's going on

huangzhen1997 · 2025-10-31T20:58:13Z

contracts/contracts/ccip/fee_quoter/contract.tolk

 get fun tokenPrice(token: address): TimestampedPrice {
    val st = lazy Storage.load();
-    return st.usdPerToken.mustGet(token, Error.TokenNotSupported as int);
+    val entry = st.usdPerToken.get(token);


Fixing this stack underflow issue https://chainlink-core.slack.com/archives/C08KVCWAZUG/p1761932964876469

huangzhen1997 · 2025-10-31T20:58:42Z

pkg/ccip/bindings/common/common.go

 	} else {
 		result, err = client.RunGetMethod(ctx, block, contractAddr, method, opts...)
 	}
+


return raw error so downstream can parse the error code

huangzhen1997 · 2025-10-31T21:00:55Z

pkg/ccip/chainaccessor/ton_accessor.go

 		result, err := a.client.RunGetMethod(ctx, block, addr, "destinationChainGasPrice", uint64(selector))
 		// The plugin is built with EVM behaviour in mind: if a value doesn't exist the zero value is returned
-		if execError, ok := err.(ton.ContractExecError); ok && execError.Code == common.ErrUnknownDestChainSelector { //nolint:errorlint // we're guaranteed to get unwrapped error here
+		if execError, ok := err.(ton.ContractExecError); ok && execError.Code == 24814 { //nolint:errorlint // we're guaranteed to get unwrapped error here


added todo. The error hard-coded here in order to match on-chain definition. There's a discrepancy of the error code definition

GetFeeQuoterTokenUpdates

5ea0ce1

huangzhen1997 marked this pull request as ready for review October 31, 2025 01:25

huangzhen1997 requested a review from a team as a code owner October 31, 2025 01:25

huangzhen1997 requested review from archseer, Copilot and ogtownsend October 31, 2025 01:25

Copilot AI reviewed Oct 31, 2025

View reviewed changes

ogtownsend reviewed Oct 31, 2025

View reviewed changes

pkg/ccip/bindings/feequoter/fee_quoter.go Outdated Show resolved Hide resolved

huangzhen1997 added 4 commits October 30, 2025 20:37

group constants

2c5ebf6

Merge branch 'main' into fix-ton-accessor

f149871

Merge branch 'main' into fix-ton-accessor

feefd7a

add comment

4e94454

ogtownsend previously approved these changes Oct 31, 2025

View reviewed changes

ogtownsend reviewed Oct 31, 2025

View reviewed changes

refactor

4c7cec5

huangzhen1997 dismissed ogtownsend’s stale review via 4c7cec5 October 31, 2025 20:54

huangzhen1997 commented Oct 31, 2025

View reviewed changes

huangzhen1997 requested a review from ogtownsend October 31, 2025 21:01

huangzhen1997 added 8 commits October 31, 2025 16:10

golint

c2f0703

tidy again

85887d5

update comment and const, fix lint

c432910

rebase main

18a750e

lint

66dac84

fix

20416f7

Merge branch 'main' into fix-ton-accessor

4694357

Merge branch 'main' into fix-ton-accessor

00090bf

huangzhen1997 force-pushed the fix-ton-accessor branch from 4bc58d6 to 00090bf Compare November 3, 2025 18:31

fix make

875ffdd

ogtownsend approved these changes Nov 3, 2025

View reviewed changes

huangzhen1997 requested a review from patricios-space November 3, 2025 23:35

patricios-space approved these changes Nov 4, 2025

View reviewed changes

patricios-space merged commit 42e2549 into main Nov 4, 2025
35 checks passed

patricios-space deleted the fix-ton-accessor branch November 4, 2025 13:24

		var tokenPrice feequoter.TimestampedPrice
		err = tokenPrice.FetchResult(ctx, a.client, block, addr, []interface{}{cell.BeginCell().MustStoreAddr(addrParsed).EndCell().BeginParse()})

Fix ton accessor GetFeeQuoterTokenUpdates #295

Fix ton accessor GetFeeQuoterTokenUpdates #295

Conversation

huangzhen1997 commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

huangzhen1997 Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

huangzhen1997 Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

huangzhen1997 Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

huangzhen1997 Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

huangzhen1997 commented Oct 31, 2025 •

edited

Loading

huangzhen1997 Oct 31, 2025 •

edited

Loading

huangzhen1997 Oct 31, 2025 •

edited

Loading

huangzhen1997 Oct 31, 2025 •

edited

Loading

huangzhen1997 Oct 31, 2025 •

edited

Loading