Skip to content

Conversation

@JohnChangUK
Copy link
Collaborator

@JohnChangUK JohnChangUK commented Oct 22, 2025

Changes

  1. register_entrypoint - Validates proof and cap address are the same.
let cap_account_address = /* extract from capability type */;
assert!(proof_account_address == cap_account_address, EProofNotAtCapAddress);
  1. Removed expected_proof_type from ExecutingCallbackParams
  • We call get_registered_proof_type() in get_callback_params_with_caps()
  1. Renamed get_callback_paramsget_accept_ownership_data
  • Each package that calls mcms_accept_ownership MUST have a McmsAcceptOwnershipProof struct defined to pass as a callback to get_accept_ownership_data.
  • Added struct name validation:
    assert!(struct_name == b"McmsAcceptOwnershipProof", EOnlyMcmsAcceptOwnershipProofAllowed);
  • Only accepts McmsAcceptOwnershipProof struct, not generic <T: drop>
  1. New Utility: params::get_struct_name()
  • "0x1::onramp::McmsAcceptOwnershipProof" → "McmsAcceptOwnershipProof"
  1. Removed registry parameter from dispatch_timelock_bypasser_execute_batch

PRs merged in

Merged pr #158 into this, which adds Publisher in OwnerCap Dynamic field

* Require `Publisher` when registering with MCMS

* Add `Publisher` to OwnerCap dynamic field
@JohnChangUK JohnChangUK marked this pull request as ready for review October 24, 2025 18:23
@JohnChangUK JohnChangUK requested a review from a team as a code owner October 24, 2025 18:23
FelixFan1992 and others added 11 commits October 24, 2025 14:36
* update calculate refills

* tests

* update versions

* update sha
* check token pool has been unregistered before destroy

* build

* upgrade sui version

* update version

* update sha
* add transformation for events when sync to transform any []byte field into hex

* remove debug log

* remove foreful conversion of []any to hex

* update codec to include slice/array to string(hex) conversion

* extend chainreader test

* update counter test contract and associated bindings

* remove stale test

* allow overriding the event return type from configs

* add test case for CCIPMessageSent event in CR

* add ExpectedEventType usage to QueryKeyWithMetadata

* merge

* add test to QueryKeyWithMetadata

* add testing methods to mock offramp contract
* store and check token pool package id to coin metadata

* update go binding
@JohnChangUK JohnChangUK force-pushed the remove-typeproof-params branch from 9046d92 to 223ef63 Compare October 25, 2025 18:33
@JohnChangUK JohnChangUK force-pushed the remove-typeproof-params branch from e6556e4 to d750ba2 Compare October 27, 2025 21:17
FelixFan1992 and others added 8 commits October 27, 2025 17:42
…move-typeproof-params

# Conflicts:
#	deployment/ops/ccip_burn_mint_token_pool/op_deploy.go
#	deployment/ops/ccip_lock_release_token_pool/op_deploy.go
#	deployment/ops/ccip_managed_token_pool/op_deploy.go
#	deployment/ops/managed_token/op_deploy.go
@JohnChangUK JohnChangUK merged commit cfaa4fb into develop Oct 28, 2025
21 of 22 checks passed
@JohnChangUK JohnChangUK deleted the remove-typeproof-params branch October 28, 2025 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants