-
Couldn't load subscription status.
- Fork 0
Remove typeproof from ExecutingCallbackParams #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+2,488
−1,824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
70802ab to
36f4654
Compare
* Require `Publisher` when registering with MCMS * Add `Publisher` to OwnerCap dynamic field
* update calculate refills * tests * update versions * update sha
* check token pool has been unregistered before destroy * build * upgrade sui version * update version * update sha
* add transformation for events when sync to transform any []byte field into hex * remove debug log * remove foreful conversion of []any to hex * update codec to include slice/array to string(hex) conversion * extend chainreader test * update counter test contract and associated bindings * remove stale test * allow overriding the event return type from configs * add test case for CCIPMessageSent event in CR * add ExpectedEventType usage to QueryKeyWithMetadata * merge * add test to QueryKeyWithMetadata * add testing methods to mock offramp contract
* store and check token pool package id to coin metadata * update go binding
9046d92 to
223ef63
Compare
e6556e4 to
d750ba2
Compare
…move-typeproof-params # Conflicts: # deployment/ops/ccip_burn_mint_token_pool/op_deploy.go # deployment/ops/ccip_lock_release_token_pool/op_deploy.go # deployment/ops/ccip_managed_token_pool/op_deploy.go # deployment/ops/managed_token/op_deploy.go
FelixFan1992
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
register_entrypoint- Validates proof and cap address are the same.expected_proof_typefromExecutingCallbackParamsget_registered_proof_type()inget_callback_params_with_caps()get_callback_params→get_accept_ownership_datamcms_accept_ownershipMUST have aMcmsAcceptOwnershipProofstruct defined to pass as a callback toget_accept_ownership_data.assert!(struct_name == b"McmsAcceptOwnershipProof", EOnlyMcmsAcceptOwnershipProofAllowed);McmsAcceptOwnershipProofstruct, not generic<T: drop>registryparameter fromdispatch_timelock_bypasser_execute_batchPRs merged in
Merged pr #158 into this, which adds
PublisherinOwnerCapDynamic field