Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: explain which resources are completion tracked #332

Merged
merged 1 commit into from
Jan 6, 2025
Merged

docs: explain which resources are completion tracked #332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cumulus_library/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@
from cumulus_library.study_manifest import StudyManifest

__all__ = ["BaseTableBuilder", "CountsBuilder", "StudyConfig", "StudyManifest"]
__version__ = "4.1.3"
__version__ = "4.2.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only because I forgot to bump the version in the last "add core__procedure" PR. With this change, you could release when you want, but I have no urgency for it.

1 change: 1 addition & 0 deletions cumulus_library/studies/core/core_templates/completion_utils.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ in this table.
SELECT
ece.encounter_id,
(
-- Every time you add a resource here, update core-study-details.md
BOOL_OR(ec.table_name = 'allergyintolerance')
AND BOOL_OR(ec.table_name = 'condition')
AND BOOL_OR(ec.table_name = 'diagnosticreport')
Expand Down
11 changes: 9 additions & 2 deletions docs/core-study-details.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,15 @@ that encounter is considered "incomplete" and may be left out of the core tables
You can see which encounters were ignored as incomplete by examining the
`core__incomplete_encounters` table which holds the ID of all incomplete encounters.

Usually, you can resolve this by running the ETL process again for the encounters,
making sure to include all associated resources.
Usually, you can resolve this by making sure you've run the ETL process
for each of the following encounter-linked resources:
- AllergyIntolerance
- Condition
- DiagnosticReport
- DocumentReference
- MedicationRequest
- Observation
- Procedure

## Optional fields

Expand Down
Loading