Repository navigation
#363 Replace magic numbers in Renderer._draw_dice with named constants - #410
Open
ahmedmajid22 wants to merge 1 commit into
Open
ahmedmajid22 wants to merge 1 commit into
ahmedmajid22 wants to merge 1 commit into
Conversation
jarl-hoyem
requested changes
Jun 16, 2026
jarl-hoyem
left a comment
jarl-hoyem
left a comment
Collaborator
There was a problem hiding this comment.
DICE_SCORE_ROW_INDEX seems strange? Needs explanation or reverse.
Again leave out type ignore
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace magic numbers in Renderer._draw_dice with named constants in constants.py.
Related Issue
Closes #363
Changes
Testing