Skip to content

fix #342: Move mypy config to pyproject.toml and add mypy to CI - #409

Open
ahmedmajid22 wants to merge 3 commits into
mainfrom
342-move-mypy-config-to-pyproject
Open

ahmedmajid22 wants to merge 3 commits into
mainfrom
342-move-mypy-config-to-pyproject

Conversation

@ahmedmajid22

Copy link
Copy Markdown
Collaborator

Closes #342

Changes:

  • Added [tool.mypy] section to pyproject.toml with strict + pretty/show_error_codes/show_error_context/show_traceback
  • Removed --strict arg from mypy pre-commit hook (now reads from pyproject.toml)
  • Added mypy install and type check step to python-package.yml CI workflow

@ahmedmajid22
ahmedmajid22 requested a review from jarl-hoyem June 5, 2026 20:34

@jarl-hoyem jarl-hoyem left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgraded to SB3[extra] due to issue in CI (pandas not found)

@jarl-hoyem
jarl-hoyem requested a review from RobMeetsAI June 16, 2026 19:32

@RobMeetsAI RobMeetsAI left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move mypy configuration from pre-commit hook to pyproject.toml

3 participants