Skip to content

Fix #233: Remove self._number_of_bots, pass number_of_bots to _create_players() #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ahmedmajid22 wants to merge 2 commits into from
Closed

Fix #233: Remove self._number_of_bots, pass number_of_bots to _create_players() #403

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb9213c
Fix #233: Remove self._number_of_bots, pass number_of_bots to _create…
ahmedmajid22 May 22, 2026
2568626
Merge branch 'main' into 233-remove-self-number-of-bots
RobMeetsAI May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions pickomino_env/pickomino.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
__all__ = ["PickominoEnv"]

import time
from typing import TYPE_CHECKING, Any
from typing import TYPE_CHECKING, Any, cast

import gymnasium as gym
import numpy as np
Expand Down Expand Up @@ -154,9 +154,8 @@ def __init__(self, number_of_bots: int = 1, render_mode: str | None = None) -> N
raise ValueError(f"render_mode must be on of {valid_modes}, got '{render_mode}'")

self._action: tuple[int, int] = 0, 0
self._number_of_bots: int = number_of_bots
self._game: Game = Game()
self._create_players()
self._create_players(number_of_bots)
# Define what the AI Agent can observe.
# Dict space gives us structured, human-readable observations.
# 6 possible faces of the dice. Max 8 dice.
Expand Down Expand Up @@ -221,11 +220,11 @@ def renderer(self) -> Renderer:
"""Get the renderer for manual play interaction."""
return self._renderer

def _create_players(self) -> None:
def _create_players(self, number_of_bots: int) -> None:
"""Create the human (agent) player (player 0) and bot opponents with assigned names."""
names = ["Alfa", "Bravo", "Charlie", "Delta", "Echo", "Foxtrot"]
self._game.players.append(self._game.you)
for i in range(self._number_of_bots):
for i in range(number_of_bots):
self._game.players.append(Player(bot=True, name=names[i]))

def _tiles_vector(self) -> np.ndarray[Any, np.dtype[Any]]:
Expand Down Expand Up @@ -331,7 +330,9 @@ def reset(
# IMPORTANT. Must call this first. Seed the random number generator.
super().reset(seed=seed)
self._game = Game(random_generator=self.np_random)
self._create_players()
tile_players_space = cast("gym.spaces.Dict", self.observation_space)["tile_players"]
num_bots = cast("gym.spaces.Box", tile_players_space).shape[0] - 1
self._create_players(num_bots)
self._game.dice.roll()
return self._current_obs(), self._get_info()

Expand Down
Loading