Add session timeout #517
Merged
Add session timeout #517
+99
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rieši #328 |
jsuchal
approved these changes
Jan 16, 2025
|
@celuchmarek mozno otazka ci ten timeout nedat konfigurovatelne alebo vlastne ze kolko trva kym ta session na karte zomrie? |
|
Tiež mi napadlo, že to hodíme do nastavení. Mne nejde ani tak o prerušenie session s kartou ako o to blokovanie eid klient prihlasovania. 5 minút mi príde taký dobrý čas, ale to som si vycucal z prsta. Dal by som do nastavení a default 5. |
|
Spravme tak |
|
|
Napísal som to do nastavení takým jednoduchým jazykom. Token session timeout by nevyzeral moc dobre. @jsuchal |
jsuchal
reviewed
Jan 17, 2025
src/main/resources/digital/slovensko/autogram/ui/gui/settings-dialog.fxml
Outdated
Show resolved
Hide resolved
|
|
@celuchmarek mierne ma tam rusi ten velmi dlhy input na nieco co bude mat maximalne 1 cifru. |
|
|
@jsuchal dal som druhé najmenšie z govuk. To najmenšie mi prišlo príliš úzke a zle by vyzeralo. |
jsuchal
reviewed
Jan 17, 2025
src/main/resources/digital/slovensko/autogram/ui/gui/settings-dialog.fxml
Outdated
Show resolved
Hide resolved
jsuchal
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toto funguje pomerne OK, prijímam pripomienky. Testoval som s eID klientom prihlásením na sk.sk. V momente ako vyprší timeout sa pýta BOK na prihlásenie a teda token sa zjavne uvoľní tak ako chceme. Pri každom použití (čiže sign) sa timeout obnoví na 5 minút.