Add support for simplify ">>" and "<<" in <imm> #345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willieyz
force-pushed
the
simplify-shifted-immediate
branch
2 times, most recently
from
72e5ba4 to
a5a3e71
Compare
mkannwischer
requested changes
Oct 15, 2025
- This commit add the "<<", ">>" support for immediate value. e.g., "movs r0,#38<<1" - this simplify support all three architecture: aarch64_neon, arch_v7m, arch_v81m. Signed-off-by: willieyz <[email protected]>
willieyz
force-pushed
the
simplify-shifted-immediate
branch
from
a5a3e71 to
95e558e
Compare
mkannwischer
approved these changes
Oct 15, 2025
Collaborator
mkannwischer
left a comment
mkannwischer
left a comment
There was a problem hiding this comment.
LGTM. Thanks @willieyz!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During PR Add instruction support for Curve25519 armv7-M optimization tasks #341, we noticed that some shifted immediate values need to be handled.
This PR adds support for simplifying shift operators (<< and >>) applied to immediate values.
For example:
movs r0, #38 << 1will be simplified tomovs r0, #76.Apply on following architecture model:
aarch_neonarch_v7march_v81m