Don't fail on missing llvm-mc #344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dop-amin
commented
Oct 13, 2025
dop-amin
commented
- Disable selftest if llvm-mc cannot be found.
- Issue warning in log.
dop-amin
force-pushed
the
llvm-mc_nofail
branch
from
0e95451 to
f78f242
Compare
dop-amin
force-pushed
the
llvm-mc_nofail
branch
from
f78f242 to
91b913a
Compare
mkannwischer
force-pushed
the
llvm-mc_nofail
branch
from
91b913a to
68c7ddd
Compare
mkannwischer
requested changes
Oct 13, 2025
Collaborator
mkannwischer
left a comment
mkannwischer
left a comment
There was a problem hiding this comment.
Sorry, missed llvm-nm and llvm-readobj before.
Since we have to change it again anyway, maybe nudge the user a little stronger to install LLVM.
dop-amin
force-pushed
the
llvm-mc_nofail
branch
2 times, most recently
from
7c2df13 to
35e44a0
Compare
* Disable selftest if llvm-mc cannot be found. * Issue warning in log.
mkannwischer
force-pushed
the
llvm-mc_nofail
branch
from
35e44a0 to
c91d35a
Compare
mkannwischer
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.