Skip to content

Achieve compatibility with Python 3.9-3.13 and add tests to CI #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mkannwischer merged 9 commits into from
May 30, 2025
Merged

Achieve compatibility with Python 3.9-3.13 and add tests to CI #225

mkannwischer merged 9 commits into from
May 30, 2025

Conversation

@mkannwischer
Copy link
Collaborator

@mkannwischer mkannwischer commented May 28, 2025

No description provided.

@mkannwischer mkannwischer changed the title CI: add tests for multiple Python >= 3.8 <= 3.13 CI: add tests for multiple Python versions >= 3.8 <= 3.13 May 28, 2025
@mkannwischer mkannwischer force-pushed the test-python-support branch from 1c7db08 to 0ad9a39 Compare May 28, 2025 06:40
@mkannwischer mkannwischer changed the title CI: add tests for multiple Python versions >= 3.8 <= 3.13 CI: Add tests for Python 3.8, ..., 3.13 May 28, 2025
@mkannwischer mkannwischer force-pushed the test-python-support branch 6 times, most recently from 16c9f0a to da9dc9e Compare May 28, 2025 09:31
@mkannwischer mkannwischer changed the title CI: Add tests for Python 3.8, ..., 3.13 CI: Add tests for Python 3.9, ..., 3.13 May 28, 2025
@mkannwischer
Copy link
Collaborator Author

mkannwischer commented May 28, 2025

Giving up on Python 3.8 - it's EOL since Oct 2024 anyway. There's at least one more problem with it - removeprefix.

@mkannwischer mkannwischer changed the title CI: Add tests for Python 3.9, ..., 3.13 Achieve compatibility with Python 3.9-3.13 and add tests to CI May 28, 2025
@mkannwischer mkannwischer marked this pull request as ready for review May 28, 2025 09:34
@mkannwischer
Copy link
Collaborator Author

mkannwischer commented May 28, 2025

This seems signifcantly slower than before. This could either be the removed @cache annotations or the changes to zip.
I'll investigate tomorrow.

@mkannwischer mkannwischer marked this pull request as draft May 28, 2025 11:08
@mkannwischer mkannwischer force-pushed the test-python-support branch 4 times, most recently from e04f906 to 5c64086 Compare May 29, 2025 08:54
@mkannwischer mkannwischer marked this pull request as ready for review May 29, 2025 10:02
@mkannwischer
Copy link
Collaborator Author

mkannwischer commented May 29, 2025

This seems signifcantly slower than before. This could either be the removed @cache annotations or the changes to zip. I'll investigate tomorrow.

I tracked it down and it was indeed caused by the removal of @cache. The problem is that Python 3.9 does not support @cache together with @staticmethod yet. I found a workaround and applied it - not nice, but it works.
We can un-do that once Python 3.9 dies later this year.

@mkannwischer
CI: Add tests for Python 3.9, ..., 3.13
47ce942
@mkannwischer
explicit from_bytes(..., byte_order='little') for Python <= 3.10 comp…
c9afbc4 
…atibility
@mkannwischer
only install sphinx+flake8 dependencies for Python >=3.10
85c1343
@mkannwischer
remove numpy dependency
1655b05
@mkannwischer
relax pandas requirement for Python 3.8 compatibility
8d1361f
@mkannwischer
install ortools 9.12 for Python >= 3.13
f7f2643
@mkannwischer
Remove strict argument from zip (for Python 3.9 compatibility)
bf8da27 
This commit removes the strict argument from all uses of zip and
instead places an equivalent assertion on the lengths of the inputs just
before the zip.
The strict argument only got added to zip in Python 3.10.
@mkannwischer
Python 3.9: workaround for combination of @cache and @staticmethod
14934d3 
Python3.9 does not support the combination of @cache and @staticmethod -
support for that was only added for Python3.10.
This commit works around that limitation without changing functionality.
@mkannwischer
adjust README
69c895d
@mkannwischer mkannwischer force-pushed the test-python-support branch from 5c64086 to 69c895d Compare May 29, 2025 11:11
@dop-amin
Copy link
Collaborator

dop-amin commented May 30, 2025

Looks good to me, 23mins for neon NTT and 2mins for helium NTT is also the expected time for it to take.
Thanks!

@mkannwischer mkannwischer merged commit d67db3c into main May 30, 2025
35 checks passed
@mkannwischer mkannwischer deleted the test-python-support branch May 30, 2025 09:38
@mkannwischer mkannwischer mentioned this pull request May 30, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mkannwischer @dop-amin