TextInput: Fix cursor and anchor offset properties not being dirty or… #8479
Conversation
… reporting wrong values when the text changes Bite the bullet and use a proxy property with a binding. Fixes #331
|
This is still missing the bit about emitting |
Maybe we need a |
|
I was thinking the same, but OTOH the callback is public API in TextInput and it was nice if it worked also when changing text. |
|
Then we could perhaps have a PropertyTracker or ChangedTracker in the TextInput (and we wouldn't need the proxy bindings) |
(fixes test failure)
... by reusing code
If we already have the text, avoid querying the property that has a binding that will query the text again.
| pub cursor_position_byte_offset: Property<i32>, | ||
| pub anchor_position_byte_offset: Property<i32>, | ||
| pub unchecked_cursor_position_byte_offset: Property<i32>, | ||
| pub unchecked_anchor_position_byte_offset: Property<i32>, |
There was a problem hiding this comment.
We could have a #[repr(C)] struct CursorPosition { cursor_pos: i32, anchor: i32 } `
then we can put that in a Property.
(But doesn't have to be in this PR, this is just a thought)
… reporting wrong values when the text changes
Bite the bullet and use a proxy property with a binding.
Fixes #331