Skip to content

figma-inspector: added em dash to the sanitizers #8320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 1, 2025

Conversation

szecket
Copy link
Member

@szecket szecket commented Apr 30, 2025

No description provided.

@szecket
Copy link
Member Author

szecket commented Apr 30, 2025

@NigelBreslaw this should fix that example you found for "Get started with variables..."

Comment on lines +105 to +112
<Checkbox.Root>
<Checkbox.Input
checked={useVariables}
onChange={(e) => setUseVariables(e.target.checked)}
/>
<Checkbox.Label>Use Figma Variables</Checkbox.Label>
</Checkbox.Root>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems unrelated. Did you mean to include the changes in this file in the commit, or did you intend to make a separate change?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I See, this PR is on top of #8321 . I suggest to either get that in first or rebase this onto master without the changes in #8321 .

Copy link
Member

@tronical tronical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two for the price of one then :-)

@szecket szecket merged commit 9062095 into slint-ui:master May 1, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants