LSP: Submit the full backtrace to the crash reporter #7323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tronical
reviewed
Jan 10, 2025
| @@ -245,6 +245,7 @@ fn main() { | |||
| } else { | |||
| writeln!(file, "unknown location") | |||
| }; | |||
| let _ = writeln!(file, "{:?}", std::backtrace::Backtrace::force_capture()); | |||
There was a problem hiding this comment.
If this is multiple lines, how come const backtrace = lines[2]; works on the TypeScript side?
There was a problem hiding this comment.
This is a single line. Looks like this:
Backtrace [{ fn: "slint_lsp::main::{{closure}}", file: "<REDACTED: user-file-path>", line: 248 }, { fn: "<alloc::boxed::Box<F,A> as core::ops::function::Fn<Args>>::call", file: "<REDACTED: user-file-path>", line: 2245 }, { fn: "std::panicking::rust_panic_with_hook", file: "<REDACTED: user-file-path>", line: 805 }, { fn: "std::panicking::begin_panic_handler::{{closure}}", file: "<REDACTED: user-file-path>", line: 671 }, { fn: "std::sys::backtrace::__rust_end_short_backtrace", file: "<REDACTED: user-file-path>", line: 170 }, { fn: "rust_begin_unwind", file: "<REDACTED: user-file-path>", line: 662 }, { fn: "core::panicking::panic_fmt", file: "<REDACTED: user-file-path>", line: 74 }, { fn: "slint_interpreter::dynamic_item_tree::instantiate::{{closure}}", file: "<REDACTED: user-file-path>", line: 1713 }, { fn: "i_slint_compiler::generator::handle_property_bindings_init::handle_property_inner", file: "<REDACTED: user-file-path>", line: 434 }]
Note that the "file", and "line" are going to be omited when the LSP is build in release.
You can see that there: https://play.rust-lang.org/?version=stable&mode=release&edition=2021&gist=a78149bd02864dcf20a843b4e270f0c7
tronical
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.