Fix Bazel build #7241
Merged
Fix Bazel build #7241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include link-data.json as core-macros build time, so that later at run-time the extracted sources don't have to be around anymore.
|
(yes, it would be nice to also do the parsing at compile time, but I couldn't figure out a way) |
|
if the problem is CARGO_MANIFEST_DIR not being defined, this will not fix it |
|
That’s not the problem here. The manifest dir problem came after this in another crate. The issue here is that the source directories of dependencies don’t exist anymore. |
ogoffart
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include link-data.json as core-macros build time, so that later at run-time the extracted sources don't have to be around anymore.