API to enable creating winit Windows with Slint's event loop #7227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t's event loop In `winit`, it is not possible to instantiate a new window without access to the `winit` event loop, which Slint manages. With this change, there is now a `create_winit_window` call on Slint's winit` back end that will enable creating `winit` windows using existing functionality. Of course, the utility of these windows is limited without access to `winit` event handling, but there are applications for which simply creating a window and instructing an external program to write into it (by passing the `HWND` on Windows or the `XId` on X11) is useful.
ogoffart
changed the title
|
Thanks for the PR. In principle, I have nothing against adding private API if that can be useful. (But this is private API so it may not stay compatible) I wonder if it would not be more useful to somehow make |
ogoffart
approved these changes
Dec 30, 2024
tronical
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
winit, it is not possible to instantiate a new window without access to thewinitevent loop, which Slint manages. With this change, there is now acreate_winit_windowcall on Slint's winitback end that will enable creatingwinit` windows using existing functionality.Of course, the utility of these windows is limited without access to
winitevent handling, but there are applications for which simply creating a window and instructing an external program to write into it (by passing theHWNDon Windows or theXIdon X11) is useful.