Use less precision when comparing vaue in slint language #5802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tronical
approved these changes
Aug 8, 2024
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
internal/interpreter/api.rs
Outdated
| @@ -10,6 +10,7 @@ use i_slint_core::model::{Model, ModelRc}; | |||
| #[cfg(feature = "internal")] | |||
| use i_slint_core::window::WindowInner; | |||
| use i_slint_core::{PathData, SharedVector}; | |||
| use i_slint_core::graphics::euclid::approxeq::ApproxEq as _; | |||
There was a problem hiding this comment.
[formatters] reported by reviewdog 🐶
Suggested change
| use i_slint_core::graphics::euclid::approxeq::ApproxEq as _; |
In rust, use f32 instead of f64 for arithmetic comparison. In the interpreter, use approx_eq The test is failling in nightly because of precision change in `log`. By using f32, it actually should work Also Revert "Disable builds with nightly Rust temporarily" This reverts commit 4afc3a2. Fixes #5722
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In rust, use f32 instead of f64 for arithmetic comparison. In the interpreter, use approx_eq
The test is failling in nightly because of precision change in
log. By using f32, it actually should workAlso Revert "Disable builds with nightly Rust temporarily" This reverts commit 4afc3a2.
Fixes #5722