Skip to content

Conversation

@task-jp
Copy link
Contributor

@task-jp task-jp commented Dec 18, 2025

  • Add RZ/A3M board configuration in CMakeLists.txt for both demos
  • Add software rotation support for portrait displays (720x1280)
  • Add touch input support with GT911 controller
  • Update west.yaml to use Renesas Zephyr fork (wip_rz branch)
  • Add board-specific config and overlay files

- Add RZ/A3M board configuration in CMakeLists.txt for both demos
- Add software rotation support for portrait displays (720x1280)
- Add touch input support with GT911 controller
- Update west.yaml to use Renesas Zephyr fork (wip_rz branch)
- Add board-specific config and overlay files
using RenderingRotation = slint::platform::SoftwareRenderer::RenderingRotation;
RenderingRotation rotation = RenderingRotation::NoRotation;
slint::PhysicalSize size;
bool software_rotation = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I‘m a little confused by the term software rotation here. Would it perhaps make more sense to say what the display orientation is (Landscape/Portrait)?

const RotationInfo m_rotationInfo;
const slint::PhysicalSize m_size;
const slint::PhysicalSize m_physicalSize;
const slint::PhysicalSize m_logicalSize;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems odd to me that a variable called logicalSize is of type PhysicalSize. Do you perhaps intend to distinguish between the physical size in natural orientation and the logical size after an added rotation?

Is it necessary to cache this value or can it perhaps be computed on the fly?

Copy link
Member

@tronical tronical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work overall - I’m pleased to see how little additional code this requires. That said, I feel the handling of the display orientation should perhaps be cleaned up. For example by generalizing it and unconditionally setting the rotation on the software renderer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants