-
Notifications
You must be signed in to change notification settings - Fork 798
Add Zephyr support for Renesas EK-RZ/A3M board #10299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
task-jp
commented
Dec 18, 2025
- Add RZ/A3M board configuration in CMakeLists.txt for both demos
- Add software rotation support for portrait displays (720x1280)
- Add touch input support with GT911 controller
- Update west.yaml to use Renesas Zephyr fork (wip_rz branch)
- Add board-specific config and overlay files
fc5cef2 to
40a12eb
Compare
- Add RZ/A3M board configuration in CMakeLists.txt for both demos - Add software rotation support for portrait displays (720x1280) - Add touch input support with GT911 controller - Update west.yaml to use Renesas Zephyr fork (wip_rz branch) - Add board-specific config and overlay files
6a55644 to
5c3fce3
Compare
| using RenderingRotation = slint::platform::SoftwareRenderer::RenderingRotation; | ||
| RenderingRotation rotation = RenderingRotation::NoRotation; | ||
| slint::PhysicalSize size; | ||
| bool software_rotation = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I‘m a little confused by the term software rotation here. Would it perhaps make more sense to say what the display orientation is (Landscape/Portrait)?
| const RotationInfo m_rotationInfo; | ||
| const slint::PhysicalSize m_size; | ||
| const slint::PhysicalSize m_physicalSize; | ||
| const slint::PhysicalSize m_logicalSize; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems odd to me that a variable called logicalSize is of type PhysicalSize. Do you perhaps intend to distinguish between the physical size in natural orientation and the logical size after an added rotation?
Is it necessary to cache this value or can it perhaps be computed on the fly?
tronical
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work overall - I’m pleased to see how little additional code this requires. That said, I feel the handling of the display orientation should perhaps be cleaned up. For example by generalizing it and unconditionally setting the rotation on the software renderer.