refactor: simplify the feature documentation generation#29
Merged
ogoffart merged 1 commit intoslint-ui:masterfrom Jan 6, 2025
AudaciousAxiom:refactor/simplify-gen
Merged
refactor: simplify the feature documentation generation#29ogoffart merged 1 commit intoslint-ui:masterfrom AudaciousAxiom:refactor/simplify-gen
ogoffart merged 1 commit intoslint-ui:masterfrom
AudaciousAxiom:refactor/simplify-gen
Conversation
This makes the default feature label more explicit, and factors out some formatting operations to only use one `write!` statement, making the generation easier to maintain and expand.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your work on this crate!
This makes the default feature label more explicit, and factors out some formatting operations to only use one
write!statement, making the generation easier to maintain and expand.I tried to preserve the 1.54 MSRV, so implicit named arguments for formatting macros are not used as they were introduced in 1.58.