Improve Dockerfile efficiency and add Docker build instructions for contributors#815
Open
TSDPRASAD88 wants to merge 1 commit intoslimtoolkit:masterfrom
Open
Improve Dockerfile efficiency and add Docker build instructions for contributors#815TSDPRASAD88 wants to merge 1 commit intoslimtoolkit:masterfrom
TSDPRASAD88 wants to merge 1 commit intoslimtoolkit:masterfrom
Conversation
Member
|
@TSDPRASAD88 I like the main idea and the key value introduced with this PR, eliminating lots of files from the docker context when the container images for the app get created. One specific thing I'm concerned about is the fact that .dockerignore has entries for I'm also curious why the selected approach is better than what's there already that excludes everything and then reincludes only what's needed: Also curious if you used AI for the PR :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the DockerSlim contributor experience by optimizing the Dockerfiles and adding clear Docker build instructions to the README.
Changes Included
Updated
build/package/docker/Dockerfileapk update && apk upgradeto follow best practicesUpdated
build/package/docker/Dockerfile.armAdded new "Building Slim from the Provided Dockerfiles" section to README
Why This Change Is Useful
These changes improve consistency, security, and contributor onboarding:
Testing
All changes tested locally on macOS (Docker Desktop).
Verified that both Dockerfiles build successfully and Slim runs inside the container.
Thanks for reviewing! Happy to make adjustments if needed.