Move Snake integration directly into smartconnpool waitlist 3/3 - #920
Draft
bgwines wants to merge 3 commits into
Draft
Move Snake integration directly into smartconnpool waitlist 3/3#920bgwines wants to merge 3 commits into
Snake integration directly into smartconnpool waitlist 3/3#920bgwines wants to merge 3 commits into
Conversation
bgwines
changed the title
Snake gating into connection poolsSnake integration directly into smartconnpool waitlist
bgwines
force-pushed
the
bwines/snake-22-smartconnpool
branch
12 times, most recently
from
August 23, 2026 05:51
6c08053 to
08cab3c
Compare
bgwines
changed the base branch from
bwines/snake-22
to
bwines/snake-22-type-params
August 23, 2026 05:53
Base automatically changed from
bwines/snake-22-type-params
to
bwines/snake-22
August 23, 2026 18:48
bgwines
force-pushed
the
bwines/snake-22-smartconnpool
branch
2 times, most recently
from
August 23, 2026 19:02
6063bdc to
2da631c
Compare
bgwines
changed the base branch from
bwines/snake-22
to
bwines/snake-22-snake-queue
August 23, 2026 19:02
bgwines
changed the title
Snake integration directly into smartconnpool waitlistSnake integration directly into smartconnpool waitlist 3/3
bgwines
force-pushed
the
bwines/snake-22-snake-queue
branch
from
August 23, 2026 19:45
74d6f67 to
fd81e7c
Compare
bgwines
force-pushed
the
bwines/snake-22-smartconnpool
branch
from
August 23, 2026 19:47
2da631c to
63d9a08
Compare
bgwines
force-pushed
the
bwines/snake-22-snake-queue
branch
2 times, most recently
from
August 23, 2026 20:13
7609baa to
484d937
Compare
bgwines
force-pushed
the
bwines/snake-22-smartconnpool
branch
2 times, most recently
from
August 23, 2026 20:46
fe6be2a to
023c0dc
Compare
bgwines
force-pushed
the
bwines/snake-22-snake-queue
branch
from
August 23, 2026 21:11
5901915 to
aaed370
Compare
bgwines
force-pushed
the
bwines/snake-22-smartconnpool
branch
from
August 23, 2026 21:11
023c0dc to
c53f6fc
Compare
bgwines
force-pushed
the
bwines/snake-22-snake-queue
branch
from
August 23, 2026 21:21
aaed370 to
c5d8643
Compare
bgwines
force-pushed
the
bwines/snake-22-smartconnpool
branch
from
August 23, 2026 21:21
c53f6fc to
ac1efb2
Compare
bgwines
force-pushed
the
bwines/snake-22-snake-queue
branch
from
August 24, 2026 02:03
c5d8643 to
4beb66b
Compare
AI assisted with development. Every line of code was either written by or carefully reviewed by me :) Signed-off-by: Brett Wines <bwines@slack-corp.com>
AI assisted with development. Every line of code was either written by or carefully reviewed by me :) Signed-off-by: Brett Wines <bwines@slack-corp.com>
AI assisted with development. Every line of code was either written by or carefully reviewed by me :) Signed-off-by: Brett Wines <bwines@slack-corp.com>
bgwines
force-pushed
the
bwines/snake-22-smartconnpool
branch
from
August 24, 2026 02:06
ac1efb2 to
6235a2d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background / Why?
Snake and smartconnpool currently maintain separate queues for the same connection wait. This replaces smartconnpool’s waitlist list with Snake’s queue so each pool has one waitlist-owned Snake and one mutex governing enqueue, dequeue, cancellation, shedding, and connection handoff. Snake no longer models connection capacity, holders, or release lifecycle; smartconnpool remains responsible for those concerns. Valve IDs and priorities flow into the waitlist only when a connection is unavailable, while unconfigured pools use an always-present disabled Snake.
Testing
go test ./go/pools/smartconnpoolgo test ./go/vt/vttablet/tabletserver/loadshedgo test ./go/vt/vttablet/tabletserver -run Test(GetConnectionLogStats|PriorityFromOptions|DebugEnv)AI assisted with development. Every line of code was either written by or carefully reviewed by me :)