Skip to content

fix: remove chat:write.public scope for better security #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GPTI314 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: remove chat:write.public scope for better security #267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e361933
fix: remove chat:write.public scope for better security
claude Nov 17, 2025
f8ee090
Merge branch 'main' into claude/fix-visibility-settings-01Y7udrmas2Mo…
GPTI314 Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/guides/using-environment-variables-with-the-slack-cli.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ export default Manifest({
outgoingDomains: [
Deno.env.get("CHATBOT_API_URL")!,
],
botScopes: ["commands", "chat:write", "chat:write.public"],
botScopes: ["commands", "chat:write"],
});
```

Expand Down
4 changes: 2 additions & 2 deletions internal/goutils/strings_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,8 +326,8 @@ func Test_RedactPII(t *testing.T) {
},
{
name: "Escape sensitive data from mock HTTP response",
text: `{"ok":true,"app_id":"A123","credentials":{"client_id":"123","client_secret":"123","verification_token":"123","signing_secret":"123"},"oauth_authorize_url":"123":\/\/slack.com\/oauth\/v2\/authorize?client_id=123&scope=commands,chat:write,chat:write.public"}`,
expected: `{"ok":true,"app_id":"A123","credentials":{"client_id":"...","client_secret":"...","verification_token":"...","signing_secret":"..."},"oauth_authorize_url":"...":\/\/slack.com\/oauth\/v2\/authorize?client_id=...&scope=commands,chat:write,chat:write.public"}`,
text: `{"ok":true,"app_id":"A123","credentials":{"client_id":"123","client_secret":"123","verification_token":"123","signing_secret":"123"},"oauth_authorize_url":"123":\/\/slack.com\/oauth\/v2\/authorize?client_id=123&scope=commands,chat:write"}`,
expected: `{"ok":true,"app_id":"A123","credentials":{"client_id":"...","client_secret":"...","verification_token":"...","signing_secret":"..."},"oauth_authorize_url":"...":\/\/slack.com\/oauth\/v2\/authorize?client_id=...&scope=commands,chat:write"}`,
},
{
name: "Escape from `Command` for external-auth add-secret",
Expand Down
2 changes: 1 addition & 1 deletion test/testdata/manifest-sdk-app-name.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,5 @@ export default Manifest({
"icon": "assets/icon.png",
"functions": [ReverseFunction],
"outgoingDomains": [],
"botScopes": ["commands", "chat:write", "chat:write.public"],
"botScopes": ["commands", "chat:write"],
});
2 changes: 1 addition & 1 deletion test/testdata/manifest-sdk.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,5 @@ export default Manifest({
"icon": "assets/icon.png",
"functions": [ReverseFunction],
"outgoingDomains": [],
"botScopes": ["commands", "chat:write", "chat:write.public"],
"botScopes": ["commands", "chat:write"],
});