-
Notifications
You must be signed in to change notification settings - Fork 227
feat(model): add underline to rich text section block element #1522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🔍 The following appears for me when listening to an underlined app mention, as expected: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1522 +/- ##
============================================
+ Coverage 73.02% 73.43% +0.40%
- Complexity 4399 4403 +4
============================================
Files 475 475
Lines 14266 13947 -319
Branches 1452 1452
============================================
- Hits 10418 10242 -176
+ Misses 2987 2845 -142
+ Partials 861 860 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zimeg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📰 Leaving comments for kind reviewers!
slack-api-model/src/test/java/test_locally/api/model/block/BlockKitTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗣️ note: The line changes to json-logs are results from automated test runs!
WilliamBergamin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
mwbrooks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏🏻 Huge feat to add underline support to the Java SDK as well!
zimeg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WilliamBergamin @mwbrooks I share the excitement for this format! 📠
For now I will make a small change to tests then merge this since I believe support is rolled out across teams!
This PR adds
underlineto the rich text section block element style.Category
Reviewers
This snippet might be useful in testing:
Notes
🏁 This style has not been released to all teams yet! Hoping to have this ready to release when this does go public!
Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.