Skip to content

build: add deno installation directory to devcontainer path#86

Merged
zimeg merged 1 commit intoslack-samples:mainfrom
Falciron:main
Dec 22, 2025
Merged

build: add deno installation directory to devcontainer path#86
zimeg merged 1 commit intoslack-samples:mainfrom
Falciron:main

Conversation

@Falciron
Copy link
Contributor

Type of change

  • New feature
  • Bug fix
  • Documentation

Summary

This PR was created to resolve Issue #85 and allow developers to use deno commands from their dev container terminal without manual intervention.

This fix, if approved, should be applied across all Deno sample apps that include the same dev container Dockerfile.

Requirements

  • I have ensured the changes I am contributing align with existing patterns and have tested and linted my code
  • I've read and agree to the Code of Conduct

@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @Falciron to sign the Salesforce Inc. Contributor License Agreement.

@zimeg zimeg closed this Dec 22, 2025
@zimeg zimeg reopened this Dec 22, 2025
@zimeg zimeg added bug Something isn't working dependencies Pull requests that update a dependency file labels Dec 22, 2025
@zimeg zimeg changed the title Update dev container Dockerfile to properly add Deno installation directory to PATH build: add deno installation directory to devcontainer path Dec 22, 2025
@zimeg
Copy link
Member

zimeg commented Dec 22, 2025

@Falciron Thanks so much for sharing this finding and fix with us - it's so appreciated 🎁 ✨

I can confirm the devcontainer build is in a better place with this change, so let's merge it and make similar updates for the other samples next 🫡

@zimeg zimeg merged commit b0ab805 into slack-samples:main Dec 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cla:signed dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants