feat: make it work with OAuth 2 #4
Conversation
|
Once my comments are all resolved, anyone else can approve this PR and you can go ahead with merging it! |
There was a problem hiding this comment.
This is structured super well! I imagine this'll be a very very helpful sample for showcasing a few very common functionalities. Really nice 👏
I agree with all of the previous comments and left a few of my own, but nothing new is blocking. Just a few nits and questions.
In the process of testing this but got caught at the localhost step 😵💫 But I did get as far as getting to the dev JIRA app and starting the localhost process. The app does run without error too! Hope to finish the review soon, but it's all looking good right now! 🚀
Co-authored-by: Kazuhiro Sera <[email protected]>
Co-authored-by: Ethan Zimbelman <[email protected]>
…samples/bolt-python-jira-functions into Initial-poc-with-workflow
Co-authored-by: Ethan Zimbelman <[email protected]>
…samples/bolt-python-jira-functions into Initial-poc-with-workflow
whenever!| mrkdwn: str = ( | ||
| ":no_entry: There is a problem with the `Create an issue` step, you did not connect a Jira Account, " | ||
| f"visit the <{CONTEXT.app_home_page_url}|App Home Page> to fix this!" | ||
| ) |
| @@ -97,7 +93,7 @@ def test_create_issue_fail(self): | |||
| mock_fail = MagicMock() | |||
| mock_complete = MagicMock() | |||
| mock_context = MagicMock(team_id=self.team_id, enterprise_id=self.enterprise_id) | |||
| mock_client = MagicMock(chat_postMessage=lambda channel, text: True) | |||
| mock_client = Mock(spec=WebClient) | |||
There was a problem hiding this comment.
This is super interesting! Nice update 👏
|
|
||
| def disconnect_account_callback(ack: Ack, context: BoltContext): | ||
| ack() | ||
| CONTEXT.jira_installation_store.delete_installation( |
There was a problem hiding this comment.
Accessing the contextual properties through BoltContext (rather than directly accessing a global singleton) would be even cleaner, but it's okay so far. If we come to think that we need more flexibility for it, we can do refactoring then.
There was a problem hiding this comment.
I've thought about this but can't seem to figure out an elegant to implement it
I'll merge this PR as is since it may be needed very soon, but I would very much appreciate an example of this in order to open a follow up PR
Type of change
Summary
This PR aims to implement a working version of the
bolt python jira functionsappTesting
Follow the steps in the
README.mdRequirements