Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: include additional function related manifest properties #18

Merged
merged 1 commit into from
Aug 13, 2024
Merged

fix: include additional function related manifest properties #18

merged 1 commit into from
Aug 13, 2024

Conversation

zimeg
Copy link
Member

@zimeg zimeg commented Aug 13, 2024

Type of change

  • New sample
  • New feature
  • Bug fix
  • Documentation

Summary

This PR adds additional details to the manifest.json file to please manifest validation endpoints with the included functions - the function_executed event and function_runtime properties are included here!

Reviewers

Create a new app with this manifest!

Requirements

  • I’ve checked my submission against the Samples Checklist to ensure it complies with all standards
  • I have ensured the changes I am contributing align with existing patterns and have tested and linted my code
  • I've read and agree to the Code of Conduct

@zimeg zimeg added the bug Something isn't working label Aug 13, 2024
@zimeg zimeg requested a review from WilliamBergamin August 13, 2024 19:35
@zimeg zimeg self-assigned this Aug 13, 2024
WilliamBergamin
WilliamBergamin approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@WilliamBergamin WilliamBergamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏

@WilliamBergamin WilliamBergamin merged commit 6009b80 into main Aug 13, 2024
5 checks passed
@WilliamBergamin WilliamBergamin deleted the fix-manifest-validate-functions branch August 13, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilliamBergamin WilliamBergamin WilliamBergamin approved these changes

Assignees

@zimeg zimeg

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zimeg @WilliamBergamin