initial implementation #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amusingaxl
requested changes
Feb 17, 2025
Contributor
amusingaxl
left a comment
amusingaxl
left a comment
There was a problem hiding this comment.
❌ Found one major issue that allows bypassing step the way it's implemented.
ℹ️ Some additional suggestions are applicable.
Co-authored-by: amusingaxl <112016538+amusingaxl@users.noreply.github.com> Signed-off-by: oddaf <106770775+oddaf@users.noreply.github.com>
Co-authored-by: amusingaxl <112016538+amusingaxl@users.noreply.github.com> Signed-off-by: oddaf <106770775+oddaf@users.noreply.github.com>
Co-authored-by: amusingaxl <112016538+amusingaxl@users.noreply.github.com> Signed-off-by: oddaf <106770775+oddaf@users.noreply.github.com>
Co-authored-by: amusingaxl <112016538+amusingaxl@users.noreply.github.com> Signed-off-by: oddaf <106770775+oddaf@users.noreply.github.com>
Co-authored-by: amusingaxl <112016538+amusingaxl@users.noreply.github.com> Signed-off-by: oddaf <106770775+oddaf@users.noreply.github.com>
0xBasset
reviewed
Feb 19, 2025
amusingaxl
requested changes
Feb 19, 2025
Contributor
amusingaxl
left a comment
amusingaxl
left a comment
There was a problem hiding this comment.
Left some additional suggestions for the deploy/init scripts.
Co-authored-by: amusingaxl <112016538+amusingaxl@users.noreply.github.com> Signed-off-by: oddaf <106770775+oddaf@users.noreply.github.com>
Co-authored-by: amusingaxl <112016538+amusingaxl@users.noreply.github.com> Signed-off-by: oddaf <106770775+oddaf@users.noreply.github.com>
Co-authored-by: amusingaxl <112016538+amusingaxl@users.noreply.github.com> Signed-off-by: oddaf <106770775+oddaf@users.noreply.github.com>
Co-authored-by: amusingaxl <112016538+amusingaxl@users.noreply.github.com> Signed-off-by: oddaf <106770775+oddaf@users.noreply.github.com>
Co-authored-by: amusingaxl <112016538+amusingaxl@users.noreply.github.com> Signed-off-by: oddaf <106770775+oddaf@users.noreply.github.com>
Co-authored-by: amusingaxl <112016538+amusingaxl@users.noreply.github.com> Signed-off-by: oddaf <106770775+oddaf@users.noreply.github.com>
Co-authored-by: amusingaxl <112016538+amusingaxl@users.noreply.github.com> Signed-off-by: oddaf <106770775+oddaf@users.noreply.github.com>
amusingaxl
requested changes
Feb 20, 2025
amusingaxl
reviewed
Feb 21, 2025
Co-authored-by: amusingaxl <112016538+amusingaxl@users.noreply.github.com> Signed-off-by: oddaf <106770775+oddaf@users.noreply.github.com>
amusingaxl
reviewed
Mar 14, 2025
amusingaxl
reviewed
Mar 14, 2025
Co-authored-by: amusingaxl <112016538+amusingaxl@users.noreply.github.com> Signed-off-by: oddaf <106770775+oddaf@users.noreply.github.com>
…/dspc into initial-implementation
amusingaxl
reviewed
Mar 14, 2025
amusingaxl
reviewed
Mar 14, 2025
Co-authored-by: amusingaxl <112016538+amusingaxl@users.noreply.github.com> Signed-off-by: oddaf <106770775+oddaf@users.noreply.github.com>
amusingaxl
reviewed
Mar 19, 2025
amusingaxl
reviewed
Mar 19, 2025
amusingaxl
reviewed
Mar 19, 2025
Co-authored-by: amusingaxl <112016538+amusingaxl@users.noreply.github.com> Signed-off-by: oddaf <106770775+oddaf@users.noreply.github.com>
* refactor: rename module (DSPC -> SPBEAM) * chore: formatting
amusingaxl
reviewed
Apr 8, 2025
Co-authored-by: amusingaxl <112016538+amusingaxl@users.noreply.github.com>
0xp3th1um
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.