duplication of code get_game_stats #168
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request addresses code duplication in the get_game_stats function found in modules/scraper.py. The refactoring consolidates the logic for handling advanced and standard game stats into a single code block to improve maintainability and readability.
issue #150
Changes:
Refactored get_game_stats function:
Merged duplicated code sections for handling game statistics into a unified logic flow.
Added a parameter, adv_stats, to toggle between advanced and standard stats without duplicating the core logic.
Simplified table selection based on the adv_stats parameter.