Skip to content

Conversation

@sg-jsonjuliane
Copy link
Contributor

PR Context

  • Type: Refactor
  • Issue Link: Redmine Issue
  • Risk Factor: Medium - Build configuration changes to support AGP 8.6.0 upgrade. All builds verified to work correctly.

Changes

Update build configuration to support AGP 8.6.0 upgrade and remove deprecated APIs.

  • Updated Gradle Wrapper from 8.4 to 8.10 in gradle/wrapper/gradle-wrapper.properties (required for AGP 8.6.0, minimum Gradle 8.7+)
  • Removed jcenter() repository references (deprecated, shut down 2021) from build.gradle (2 locations)
  • Migrated lintOptions to lint {} API in TripKitAndroidUI/build.gradle and tripkituisample/build.gradle
  • Removed buildToolsVersion from TripKitAndroidUIModules/TripKitAndroidUIData/build.gradle and TripKitAndroidUIModules/TripKitAndroidUIDomain/build.gradle (AGP 8.x manages automatically)

Checklist for Reviewers

Documentation and Code Quality

  • KDocs Documentation: Build configuration changes, no new classes or functionality requiring KDocs
  • Architectural Patterns: No architectural changes, build system upgrade only

Testing and Reliability

  • Unit Testing: Build configuration changes, no code changes requiring new unit tests
  • Emulator and Real Device Testing: Builds verified successfully:
    • :TripKitAndroidUI:assemble - BUILD SUCCESSFUL
    • :TripKitAndroidUI:assembleRelease - BUILD SUCCESSFUL

Error Handling and Logging

  • Error Handling: Build configuration changes, no runtime error handling changes
  • Logging: No logging changes required

Testing Procedure

Run the following commands to verify the changes. Note: Build commands can be run from either the root project directory (tripgo-v5-android) or from the tripkit-android-ui directory:

# Verify builds succeed (can run from tripkit-android-ui directory OR root project)
cd tripkit-android-ui
./gradlew :TripKitAndroidUI:assemble
./gradlew :TripKitAndroidUI:assembleRelease
# Expected: BUILD SUCCESSFUL

# Alternative: Run from root project directory
cd ..
./gradlew :TripKitAndroidUI:assemble
./gradlew :TripKitAndroidUI:assembleRelease
# Expected: BUILD SUCCESSFUL

# Verify deprecated APIs removed (run from tripkit-android-ui directory)
cd tripkit-android-ui
grep -r "lintOptions\|buildToolsVersion\|jcenter()" --include="*.gradle" . 2>/dev/null | grep -v "PR_\|GRADLE_AGP\|README\|tripkit-android/" || echo "✓ No deprecated APIs found"
# Expected: No matches (or only in comments/documentation)

Work-in-Progress (WIP)

  • Gradle Wrapper updated to 8.10
  • All build configuration changes completed
  • Gradle Wrapper updated to 8.10
  • All builds verified (from root and independently) (from root and independently)
  • Deprecated APIs migrated

Remember to keep this template updated based on the feedback and evolving project standards.

- Remove jcenter() repository references
- Migrate lintOptions to lint API
- Remove buildToolsVersion (handled automatically by AGP 8.x)
- Updated Gradle Wrapper from 8.4 to 8.10
- Required for AGP 8.6.0 (minimum Gradle 8.7+)
- Enables TripKit Android UI modules to build independently with new toolchain
- Update to latest commit with Gradle Wrapper 8.10 upgrade
- Update to latest commit with TripKitSamples namespace fix
@github-actions
Copy link

✅ Unit tests passed successfully!

Test results are available under the "Artifacts" section of this run in GitHub Actions.

Please ensure the code is reviewed before proceeding with the merge.

@github-actions
Copy link

github-actions bot commented Jan 5, 2026

This pull request is stale because it has been open 5 days with no activity.

@github-actions github-actions bot added the stale No updates, stale PR label Jan 5, 2026
@sg-jsonjuliane sg-jsonjuliane merged commit 08ce1c7 into develop Jan 5, 2026
1 check passed
@sg-jsonjuliane sg-jsonjuliane deleted the refactor/25083-gradle-update branch January 5, 2026 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale No updates, stale PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants