[21479] Dark Mode Support #235

sg-jsonjuliane · 2025-12-16T20:16:36Z

PR Context

Type: Feature
Issue Link: Redmine Issue
Risk Factor: Medium - Dark mode implementation affects UI components, icon tinting, and map markers. Requires testing across different themes and transport modes.

Changes

Describe your changes in detail, highlighting the problem it solves or the feature it adds.

Theme Migration: Migrated TripKitAndroidUI and TripKitUISample themes to DayNight for automatic dark mode support
Color Resources: Added values-night/colors.xml with dark mode color variants for all UI components (including icon_tint_default and transport_mode_selector colors)
Layout Fixes: Updated 59 layout files:
- Backgrounds: @android:color/white → @color/white (40+ instances)
- Text colors: @android:color/black → @color/black on neutral backgrounds (20+ instances)
- Icon tinting: Added app:tint for 51+ icons (transport icons, checkmarks, UI elements)
- Contrast fixes: Fixed favorite button, "Required" badge, Google icon visibility
- Hardcoded hex colors: Replaced with semantic color resources
Drawable Fixes: Updated 9 drawable files (vector icons and shape drawables use semantic colors)
Icon Tinting Strategy: Implemented ThemeAwareApplyTintStrategy for theme-aware transport icon tinting:
- White tint in dark mode for visibility
- Original service colors in light mode
- Branding icons (e.g., Beam) protected from tinting
WheelView Dark Mode: Added dark mode support for WheelView components (TimeDatePickerFragment):
- Theme-aware top/bottom shadows (dark in light mode, light in dark mode)
- Theme-aware horizontal divider lines (black in light mode, white in dark mode)
- Uses reflection to access private WheelView fields
Map Markers: Darkened map pin markers to 60% gray in dark mode for better visibility on dark map backgrounds
Map Style & Info Windows: Added dark mode support for map style and info windows
Transport Mode Selector: Updated transport mode selector buttons with theme-aware background colors (checked/unchecked states)
Layout Tint Removal: Removed layout-level app:tint attributes that interfered with branding icons
Submodule Updates: Updated tripkit-android submodule reference to include booking UI dark mode support

Checklist for Reviewers

Documentation and Code Quality

KDocs Documentation: Are all changes, new functionalities, and classes documented with KDocs?
Architectural Patterns: Is there consistent and proper use of architectural patterns (e.g., MVVM, MVP)?

Testing and Reliability

Unit Testing: Are there unit tests for all new functionalities and classes?
Emulator and Real Device Testing: Has the application been tested on both emulators and real devices to ensure compatibility?

Error Handling and Logging

Error Handling: Are errors and exceptions caught and handled gracefully, ensuring the app remains stable?
Logging: Is there proper logging in place for critical errors and information, aiding in debugging and monitoring?

Testing Procedure

If applicable, provide steps or commands for testing your changes. This can help reviewers and testers.

Test TimeDatePickerFragment in both light and dark modes - verify shadows and dividers are visible
Verify transport icons are properly tinted in dark mode (white) while branding icons remain unchanged
Test map markers in dark mode - verify pins are visible (60% gray) on dark map background
Verify transport mode selector buttons have correct background colors in both themes
Test theme switching and verify all UI components adapt correctly

Work-in-Progress (WIP)

List any remaining work or areas that need additional focus. This section can be updated as the work progresses.

Comprehensive testing across all transport modes and icon types
Verify branding icons are not affected by tinting in all scenarios

Remember to keep this template updated based on the feedback and evolving project standards.

…o DayNight - TripKitAndroidUI: Updated 3 dialog/component themes to DayNight - FullScreenDialog: Theme.AppCompat.Light.Dialog → DayNight.Dialog - Widget.CalendarView.Custom: Theme.MaterialComponents.Light → DayNight - FlatDialog: Fixed @android:color/white → @color/white - tripkituisample: Theme.MaterialComponents.Light.NoActionBar → DayNight.NoActionBar - Updated tripkit-android submodule reference (clean commit with .gitignore fix) Part of Phase 1: Core Theme Migration for dark mode support

- Updated tripkit-android submodule reference

- Add night-res map style JSON for dark mode map styling - Remove custom backgrounds from all info window layouts to use Google's default styling - Update info window text colors to use @android:color/black (no night variant) for visibility - Remove custom icon tinting from info windows to use default colors - Updated layouts: - map_pin_info_window.xml - free_floating_vehicle_info_window.xml - bike_share_info_window.xml - view_simple_callout.xml - city_callout.xml

…k mode fixes - Add ThemeAwareApplyTintStrategy for theme-aware icon tinting when service colors disabled - Update GetTransportIconTintStrategy to use ThemeAwareApplyTintStrategy when service colors disabled - Remove tint from trip_result_segment_item.xml to allow branding icons (Beam) to display correctly - Remove tint from trip_result_list_transport_item.xml, handle theme via background colors - Update trip_result_transport_mode_selector_background.xml with theme-aware colors - Add transport_mode_selector_checked and transport_mode_selector_unchecked color resources - Fix TimeDatePickerFragment dark mode: shadows, divider lines, and date column text - Add top_shadow and bottom_shadow drawables with night variants - Update SuggestionViewModel with programmatic icon tinting for search results - Update various layouts with app:tint for dark mode icon visibility

… mode

github-actions · 2025-12-16T21:17:20Z

✅ Unit tests passed successfully!

Test results are available under the "Artifacts" section of this run in GitHub Actions.

Please ensure the code is reviewed before proceeding with the merge.

github-actions · 2025-12-22T02:14:29Z

This pull request is stale because it has been open 5 days with no activity.

MichaelReyes · 2025-12-22T13:34:18Z

TripKitAndroidUI/src/main/java/com/skedgo/tripkit/ui/dialog/TimeDatePickerFragment.kt

+        setWheelViewShadows(mDaysView)
+        setWheelViewShadows(mHoursView)
+        setWheelViewShadows(mMinutesView)
+        setWheelViewShadows(mAmPmView)
+
+        // Set center drawable and divider lines for dark mode support
+        setWheelViewCenterDrawable(mDaysView)
+        setWheelViewCenterDrawable(mHoursView)
+        setWheelViewCenterDrawable(mMinutesView)
+        setWheelViewCenterDrawable(mAmPmView)


Hi @sg-jsonjuliane , just wanted to clarify, is this intended for dark mode only? If so, do we need a checker to detect whether the device is in dark mode? If not, then all good. Thanks.

This applies to both. There are already separate day and night variants for the drawables being used, so they will adjust automatically.

MichaelReyes · 2025-12-22T13:53:07Z

TripKitAndroidUI/src/main/java/com/skedgo/tripkit/ui/tripresults/ThemeAwareApplyTintStrategy.kt

+    private fun isDarkMode(): Boolean {
+        val nightModeFlags = resources.configuration.uiMode and Configuration.UI_MODE_NIGHT_MASK
+        return nightModeFlags == Configuration.UI_MODE_NIGHT_YES
+    }


Hi @sg-jsonjuliane, I noticed this is also being called in another part of the code. Maybe we can add an extension using Resources (e.g., fun Resources.isDarkMode()) and call it from there instead. Thanks 🙇

MichaelReyes · 2025-12-22T13:59:04Z

TripKitAndroidUI/src/main/res/drawable/top_shadow.xml

+<?xml version="1.0" encoding="utf-8"?>
+<shape xmlns:android="http://schemas.android.com/apk/res/android">
+    <gradient
+        android:startColor="#FFFFFF"


Hi @sg-jsonjuliane, in other parts we replaced hardcoded colors with values from resources. Maybe we should do the same here as well. Thanks 🙇

MichaelReyes

Hi @sg-jsonjuliane, I have a few minor comments, but aside from those, everything looks good 👍

… drawables

github-actions · 2025-12-22T17:05:08Z

✅ Unit tests passed successfully!

Test results are available under the "Artifacts" section of this run in GitHub Actions.

Please ensure the code is reviewed before proceeding with the merge.

sg-jsonjuliane added 8 commits December 17, 2025 04:04

[21479] Provided initial night/colors for TripKitAndroidUI

783b158

[21479] Phase 2: Apply TripKitAndroidUI dark mode fixes

5d89456

[21479] Phase 2: Finalize shared drawable palette

0e18a0c

[21479] Phase 2: Priority 3 - trip-kit-booking-ui dark mode support

e2ebcd6

- Updated tripkit-android submodule reference

[21479] Adjust map pin tint to 60% gray for better visibility in dark…

70cb6b9

… mode

sg-jsonjuliane requested a review from MichaelReyes December 16, 2025 20:16

sg-jsonjuliane self-assigned this Dec 16, 2025

This comment was marked as outdated.

Sign in to view

[21479] Bump tripkit-android submodule (booking-ui @color/white fix)

749ff4f

github-actions bot added the stale No updates, stale PR label Dec 22, 2025

MichaelReyes reviewed Dec 22, 2025

View reviewed changes

MichaelReyes requested changes Dec 22, 2025

View reviewed changes

sg-jsonjuliane added 2 commits December 23, 2025 00:06

[21479] Refactor isDarkMode() to Resources extension function

1f9492a

[21479] Replace hardcoded #FFFFFF with @android:color/white in shadow…

cdb898f

… drawables

github-actions bot removed the stale No updates, stale PR label Dec 23, 2025

MichaelReyes approved these changes Dec 23, 2025

View reviewed changes

sg-jsonjuliane merged commit 5042669 into develop Dec 23, 2025
1 check passed

sg-jsonjuliane deleted the feature/21479-dark-mode-support branch December 23, 2025 16:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[21479] Dark Mode Support #235

[21479] Dark Mode Support #235

Uh oh!

sg-jsonjuliane commented Dec 16, 2025

Uh oh!

This comment was marked as outdated.

github-actions bot commented Dec 16, 2025

Uh oh!

github-actions bot commented Dec 22, 2025

Uh oh!

MichaelReyes Dec 22, 2025

Uh oh!

sg-jsonjuliane Dec 22, 2025

Uh oh!

MichaelReyes Dec 22, 2025

Uh oh!

MichaelReyes Dec 22, 2025

Uh oh!

MichaelReyes left a comment

Uh oh!

github-actions bot commented Dec 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[21479] Dark Mode Support #235

[21479] Dark Mode Support #235

Uh oh!

Conversation

sg-jsonjuliane commented Dec 16, 2025

PR Context

Changes

Checklist for Reviewers

Documentation and Code Quality

Testing and Reliability

Error Handling and Logging

Testing Procedure

Work-in-Progress (WIP)

Uh oh!

This comment was marked as outdated.

github-actions bot commented Dec 16, 2025

Uh oh!

github-actions bot commented Dec 22, 2025

Uh oh!

MichaelReyes Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

sg-jsonjuliane Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

MichaelReyes Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

MichaelReyes Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

MichaelReyes left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants