refactor(Code style): add eslint rules for consistent type imports#3535
Open
mshatikhin wants to merge 6 commits intonextfrom
Open
refactor(Code style): add eslint rules for consistent type imports#3535mshatikhin wants to merge 6 commits intonextfrom
mshatikhin wants to merge 6 commits intonextfrom
Conversation
mshatikhin
force-pushed
the
code-style
branch
2 times, most recently
from
0b4ada9 to
e16a421
Compare
mshatikhin
force-pushed
the
code-style
branch
from
e16a421 to
b60bae5
Compare
mshatikhin
changed the title
mshatikhin
force-pushed
the
code-style
branch
from
b60bae5 to
7f45f13
Compare
mshatikhin
force-pushed
the
code-style
branch
from
ac52e1a to
b843102
Compare
mshatikhin
force-pushed
the
code-style
branch
from
b843102 to
1dc5332
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Проблема
Решение
Фича import type появилась очень давно (в ts 3.8) https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export
Включаем правило в eslint, выполняем fix
Ссылки
Чек-лист перед запросом ревью
Добавлены тесты на все изменения
⬜ unit-тесты для логики
⬜ скриншоты для верстки и кросс-браузерности
✅ нерелевантно
Добавлена (обновлена) документация
⬜ styleguidist для пропов и примеров использования компонентов
⬜ jsdoc для утилит и хелперов
⬜ комментарии для неочевидных мест в коде
⬜ прочие инструкции (
README.md,contributing.mdи др.)✅ нерелевантно
Изменения корректно типизированы
⬜ без использования
any(см. PR2856)✅ нерелевантно
Прочее
✅ все тесты и линтеры на CI проходят
✅ в коде нет лишних изменений
✅ заголовок PR кратко и доступно отражает суть изменений (он попадет в changelog)