feat: implement delete() in JsonDBItem for sdb:select-item support #820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 8, 2026 01:25
Implements the delete() method from UpdatableJsonItem interface,
enabling JSONiq delete expressions to work with sdb:select-item().
Changes:
- Add default delete() implementation in JsonDBItem interface
- Add test testRemoveFromObjectViaSdbSelectItem() to verify functionality
This allows queries like:
delete json sdb:select-item(jn:doc('db','res'), nodeKey)
Requires Brackit feature/sdb-select-item-delete-support branch.
Implements the delete() method from UpdatableJsonItem interface,
enabling JSONiq delete expressions to work with sdb:select-item().
Changes:
- Add default delete() implementation in JsonDBItem interface
- Add test testRemoveFromObjectViaSdbSelectItem() to verify functionality
This allows queries like:
delete json sdb:select-item(jn:doc('db','res'), nodeKey)
Requires Brackit feature/sdb-select-item-delete-support branch.
JohannesLichtenberger
force-pushed
the
feature/sdb-select-item-delete-support
branch
from
bdad3b0 to
bf73b0b
Compare
Tests that when both replace and delete operations target the same item, the replace is skipped and only the delete is applied, per XQuery Update Facility 1.0 section 3.2.1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the delete() method from UpdatableJsonItem interface, enabling JSONiq delete expressions to work with sdb:select-item().
Changes:
This allows queries like:
delete json sdb:select-item(jn:doc('db','res'), nodeKey)
Requires Brackit feature/sdb-select-item-delete-support branch.