Update dependencies including ESlint 9 upgrade#19
Draft
YasharF wants to merge 1 commit intosinonjs:mainfrom
Draft
Update dependencies including ESlint 9 upgrade#19YasharF wants to merge 1 commit intosinonjs:mainfrom
YasharF wants to merge 1 commit intosinonjs:mainfrom
Conversation
|
New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
Author
|
I can take a stab at upgrading sinonjs modules that consume eslint-config for further validation, if you don't have any overall issues with the changes and just need further validation and testing. |
Author
|
I changed the status to draft as I need to update the documentation on using this new version and how to migrate existing consumers. I will try to do that in the next few weeks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking Change
Upgraded eslint to v9: Migrated configurations to eslint.config.js and set up the structure (index.js) so eslint.config.js can be used for linting this project and its consumers.
Upgrades
Upgraded husky to the latest version: Configured husky hook to run npm test in addition to lint-staged.
Upgraded other dependencies to their latest versions.
Improvements
Enhanced lint-staged configurations:
eslint --fixTO DO (Draft until done)
Testing and validation:
npm testandnpm run lintwithin this project pass.npm run lintin samsam is as follows. Two new errors have surfaced for no-unused-vars, but upon review of samsam, I noticed that there are unused variables present which were being missed by the prior eslint and configs.