[MacOS] Add arm64 support. #315
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| && ln -s ${THIRD_PARTY} ${DAS_DIR}/src/3rd-party \ | ||
| && mv bazelisk ${BAZEL_DIR} | ||
| COPY src/assets/bazelisk.tgz /tmp | ||
| RUN ARCH=$(if [ "$(uname -m)" = "aarch64" ]; then echo "arm64"; else echo "amd64"; fi) \ |
There was a problem hiding this comment.
Suggested change
| RUN ARCH=$(if [ "$(uname -m)" = "aarch64" ]; then echo "arm64"; else echo "amd64"; fi) \ | |
| RUN ARCH=$([ "$(uname -m)" = "aarch64" ] && echo "arm64" || echo "amd64") \ |
| @@ -30,7 +32,7 @@ py_wheel( | |||
| description_content_type = "text/markdown", | |||
| description_file = "README.md", | |||
| distribution = "hyperon_das_atomdb_cpp", | |||
| platform = "manylinux_2_28_x86_64", | |||
| platform = "any", | |||
There was a problem hiding this comment.
This will be a possible issue when publishing the module on PyPI.
Comment on lines
40
to
-42
|
|
||
| docker run --rm \ | ||
| --user="$(id -u)":"$(id -g)" \ |
There was a problem hiding this comment.
Please, bind the user ID and group as env vars:
docker run --rm \
--name=$CONTAINER_NAME \
-e HOST_USER_ID="$(id -u)" \
-e HOST_USER_GROUP="$(id -g)" \
-e BIN_DIR=$CONTAINER_BIN_DIR \
<rest of the command> . . .And then, at the end of bazel_build.sh, before the exit, add this:
[ "${HOST_USER_ID:-x}" != "x" -a "${HOST_USER_GROUP:-x}" != "x" ] && \
chown -R ${HOST_USER_ID}:${HOST_USER_GROUP} "$BIN_DIR"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting the journey to support MacOS (arm64) arch.
make build-all[works withoutevolutionand pythonwheels, check the bellow notes]make test-all(breaking due to unrelated issue)tests,evolutionand pythonwheelsbuild are working with b5be17d