Skip to content

Add support for funkeyOS.#18

Open
sam1am wants to merge 3 commits into
sinedied:mainfrom
sam1am:main
Open

Add support for funkeyOS.#18
sam1am wants to merge 3 commits into
sinedied:mainfrom
sam1am:main

Conversation

@sam1am

@sam1am sam1am commented Nov 17, 2025

Copy link
Copy Markdown

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for FunkeyOS as a new output format for artwork. FunkeyOS stores artwork images directly alongside the ROM files (same directory, same filename with .png extension), unlike formats such as MinUI or Anbernic that use dedicated sub-folders.

Changes:

  • New src/format/funkey.ts module implementing the OutputFormat interface for FunkeyOS.
  • Format.Funkey enum value added and its case handled in getOutputFormat in format.ts.
  • CLI help text updated to list funkey as a valid output format option.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/format/funkey.ts New format module implementing artwork export/cleanup for FunkeyOS
src/format/format.ts Adds Funkey enum value and dynamic import case for the new format
src/cli.ts Updates the --output option description to include funkey

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/format/funkey.ts
if (artTypes.art2 && (art1Url ?? art2Url)) {
debug(`Found art URL(s): "${art1Url}" / "${art2Url}"`);
await composeImageTo(art1Url, art2Url, artPath, { width: options.width, height: options.height });
} else if art1Url) {

Copilot AI Mar 4, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a syntax error on this line: the opening parenthesis ( is missing before art1Url. The condition should be else if (art1Url) to match the syntax used in the equivalent code in anbernic.ts and minui.ts. As written, this file will fail to compile/parse entirely.

Suggested change
} else if art1Url) {
} else if (art1Url) {

Copilot uses AI. Check for mistakes.
@sinedied

sinedied commented Apr 9, 2026

Copy link
Copy Markdown
Owner

@sam1am your last force push contains a malicious script for blockchain, you should check your computer if that was not voluntary

sam.garfield and others added 2 commits May 27, 2026 15:42
The injected .vscode/tasks.json auto-ran obfuscated JS disguised as fa-solid-400.woff2 on folder open; the fonts directory and related .gitignore entries were not used by these projects.
Remove PolinRider malware (VS Code tasks + fake font payload)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants