Skip to content

fix: Remove use of reduce in keysSorter function #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
theluckystrike wants to merge 3 commits into from
+6 −5
Closed

fix: Remove use of reduce in keysSorter function #416

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b52c75f
fix: Remove use of reduce in keysSorter function
Mar 3, 2026
e87c201
fix: add blank line before return to satisfy linting rule
Mar 3, 2026
63ee1b1
ci: re-run tests
theluckystrike Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions base.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,13 +418,14 @@ export function parse(query, options) {
return returnValue;
}

// TODO: Remove the use of `reduce`.
// eslint-disable-next-line unicorn/no-array-reduce
return (options.sort === true ? Object.keys(returnValue).sort() : Object.keys(returnValue).sort(options.sort)).reduce((result, key) => {
const sortedKeys = options.sort === true ? Object.keys(returnValue).sort() : Object.keys(returnValue).sort(options.sort);
const result = Object.create(null);
for (const key of sortedKeys) {
const value = returnValue[key];
result[key] = Boolean(value) && typeof value === 'object' && !Array.isArray(value) ? keysSorter(value) : value;
return result;
}, Object.create(null));
}

return result;
}

export function stringify(object, options) {
Expand Down