prefer-bigint-literals: Support signed numbers and strings

[baevm]

Fixes #2733, added support for BigInt('+1'), BigInt('-1'), BigInt(+1), BigInt(-1). Not sure about BigInt(!1) and BigInt(~1), looks like those also valid?

[fisker]

I opened #2733, because I think there are maybe people writes BigInt("-1"), but I don't think anyone would write BigInt(!1), it should be a mistake.

[fisker]

I didn't notice, this is a PR, not an issue. Sorry!

[fisker]

Can you add test for BigInt("++1")?

[fisker]

And BigInt("+ 1")

[fisker]

BigInt(" -1 ")

BigInt(" +1 ")

[baevm]

added tests:
BigInt("++1") - valid
BigInt("+ 1") - valid

BigInt(" -1 ") - invalid
BigInt(" +1 ") - invalid with suggestion

[fisker]

Need test -BigInt(-1) and -BigInt("-1"), I think they will fail.

[fisker]

There can also ASI issue since the fixed code inserts -.

foo // <-- no semicolon here
BigInt("-1")

[baevm]

Need test -BigInt(-1) and -BigInt("-1"), I think they will fail.

fixed, added tests

There can also ASI issue since the fixed code inserts -.

foo // <-- no semicolon here
BigInt("-1")

not sure about this, but i think it is working fine? added test for this

[fisker]

Another test 2n - BigInt("-1")

[sindresorhus]

Bump :)

[baevm]

Another test 2n - BigInt("-1")

added test case 2n - BigInt("-1") -> 2n - -1n

[fisker]

Sorry, I mean 2n -BigInt("-1"), but should already fixed .

[baevm]

Sorry, I mean 2n -BigInt("-1"), but should already fixed .

fixed, 2n -BigInt("-1") -> 2n -(-1n)

also added check for cases like this: +BigInt(1), it throws TypeError so i think it should not report on these

[fisker]

I'm taking a final look.

[fisker]

I pushed some simplification, can you take a look?

[fisker]

Same runtime error, this is not what we should care.

+BigInt(1)
VM782:1 Uncaught TypeError: Cannot convert a BigInt value to a number
    at <anonymous>:1:1
(anonymous) @ VM782:1

+1n
VM792:1 Uncaught TypeError: Cannot convert a BigInt value to a number
    at <anonymous>:1:1