Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: action lint double link in readme #1815

Closed
wants to merge 1 commit into from
Closed

feat: action lint double link in readme #1815

wants to merge 1 commit into from

Conversation

Scrum
Copy link

@Scrum Scrum commented Jul 2, 2020

No description provided.

@sindresorhus
Copy link
Owner

Can you fill out the PR description field?

@Scrum
Copy link
Author

Scrum commented Jul 3, 2020

Can you fill out the PR description field?

My request does not belong to the awesome list, it adds github action which checks PR for duplication of links in yours readme.md

I can also add your wonderful package to it awesome-lint

@sindresorhus
Copy link
Owner

I said "field", not "template", as in just writing a description of the PR as it was not immediately clear what it was about. A PR description field should rarely be blank.

@sindresorhus
Copy link
Owner

This looks useful, but I think it would be better to integrate the check into awesome-lint instead and then get #1794 done.

Ideally, the check would be a remark-lint, so the Markdown doesn't have to be parsed multiple times.

@Scrum Scrum deleted the feat/lint-double-link branch July 6, 2020 06:06
@Scrum
Copy link
Author

Scrum commented Jul 10, 2020

@sindresorhus First step is done remarkjs/remark-lint#241

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants