[Gear] Trinket - Sszorak's Ferocity - #11791
Merged
renanthera merged 2 commits intoAug 27, 2026
Merged
Conversation
renanthera
requested changes
Aug 26, 2026
…he buff to trigger the follow-up action. Without the extra check, double triggers were rarely observed in debugger even with `dbc_proc_callback_t::activate_with_buff` being used.
Member
|
For additional clarity, trigger condition is satisfied so it can occasionally schedule multiple execute events. As the execute event hasn't occurred, expiration hasn't occurred. There's a few ways to correct this behaviour, but dd0250b is one possible (and in this case fairly minimal) fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.