[Mage] Implement BoP and GI bug + Fix Arcane's Spellfire Spheres tracking #10432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| auto check_stacks = [ this, s = max_stacks ] | ||
| // Expiration of Spellfire Spheres needs to occur instantly as to have Blast (while at 5 spheres) with a queued Barrage end with 1 spheres. | ||
| // Otherwise, the 15ms delay will nullify the queued increment because spheres are at max stacks for an extra 10ms. | ||
| bool max_stacks = buffs.spellfire_spheres->at_max_stacks(); |
There was a problem hiding this comment.
So, the way I wrote this is to write around the current Implementation of Spheres instead of directly changing it, I suppose.
What I'm trying to ask is whether or not I should rewrite 9900-9914 to handle the delay + expiration all in one block instead of separating them -- anything works with me. Let me know, thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.