-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…5 file if we want to start using it again
Fix issue 175 Closed issue #175
…_helpers_new, and change imports accordingly
Modified to allow extract_run_summaries_from_mth5s to accept mth5 objects as well as (already supported) types of pathlib.Path or str
The new config is now being used in new (duplicates) of all the tests.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is being prepared in advance. Merging dev into main in this case will correspond to closing issue #153 (and its duplicate #30), and significant progress towards #80 , #118, #132
SubTasks to address:
test_synthetic_driver.py uses the updated processing configs.
The initialize_config method in pipelines/helpers.py is updated
Address storage of json files in synthetic processing config for the aurora_vs_emtf tests.
test_stft_methods_agree.py uses the updated processing configs.
Reconcile two versions of get_data_from_mth5_new (in time_series_helpers and time_series_helpers_new.)
remove duplicate process_mth5_run method from process_mth5_dev
remove duplicate get_data_from_mth5 in (in time_series_helpers and time_series_helpers_new.)
Confirm no issue removing close_mth5() from synthetic/test_stft_methods_agree
replace time_series_helpers.py with time_series_helpers_new.py
-This is ready, just need to deprecate old time_series_helpers dependencies
replace transfer_function_helpers.py with transfer_function_helpers_new.py
replace pipelines/helpers.py with pipelines/helpers_new.py
-This is ready, just need to deprecate old pipelines/helpers dependencies
Modify Parkfield tests to use new processing class
Remove duplicate method channel_summary_to_dataset_definition()
Test channel_scale_factors (can scale individual channels)
created issue Add handling of channel_scale_factors to new Processing class #175 to address this
Modify run_summary to return actual input/output channel lists based on what is present in channel summary
Modify operate_aurora ipynb to use new pipeline tools
-Made operate_aurora_new.ipynb to test
Add start and end times usage to populate_dataset_df so that partial runs are supported