Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #167

Merged
merged 167 commits into from
May 28, 2022
Merged

Dev #167

merged 167 commits into from
May 28, 2022

Conversation

kkappler
Copy link
Collaborator

@kkappler kkappler commented Apr 22, 2022

This pull request is being prepared in advance. Merging dev into main in this case will correspond to closing issue #153 (and its duplicate #30), and significant progress towards #80 , #118, #132

SubTasks to address:

  • test_synthetic_driver.py uses the updated processing configs.

  • The initialize_config method in pipelines/helpers.py is updated

    • Handled this by creating helpers_new.py which will overwrite helpers.py when this PR completes
  • Address storage of json files in synthetic processing config for the aurora_vs_emtf tests.

  • test_stft_methods_agree.py uses the updated processing configs.

  • Reconcile two versions of get_data_from_mth5_new (in time_series_helpers and time_series_helpers_new.)

  • remove duplicate process_mth5_run method from process_mth5_dev

  • remove duplicate get_data_from_mth5 in (in time_series_helpers and time_series_helpers_new.)

  • Confirm no issue removing close_mth5() from synthetic/test_stft_methods_agree

  • replace time_series_helpers.py with time_series_helpers_new.py

    • Added deprecation warnings to time_series_helpers.py
      -This is ready, just need to deprecate old time_series_helpers dependencies
  • replace transfer_function_helpers.py with transfer_function_helpers_new.py

    • Added deprecation warnings to transfer_function_helpers.py
    • This is ready, just need to deprecate old transfer_function_helpers dependencies
  • replace pipelines/helpers.py with pipelines/helpers_new.py

    • Added deprecation warnings to helpers.py
      -This is ready, just need to deprecate old pipelines/helpers dependencies
  • Modify Parkfield tests to use new processing class

    • test_calibrate_parkfield.py
    • test_process_parkfield.py
      • This was handled by removing this antiquated, and redundant test
    • test_process_parkfield_run.py
      • Created test_process_parkfield_run_new.py
      • Added deprecation warnings to test_process_parkfield_run.py
      • Overwrite test_process_parkfield_run.py with test_process_parkfield_run_new.py
    • test_process_parkfield_run_rr.py
      • Created test_process_parkfield_run_rr_new.py
      • Added deprecation warnings to test_process_parkfield_run_rr.py
      • Overwrite test_process_parkfield_run_rr.py with test_process_parkfield_run_rr_new.py
    • Deprecate make_processing_configs.py
      • Added deprecation warnings to parkfield/make_processing_configs.py
  • Remove duplicate method channel_summary_to_dataset_definition()

    • One version in sandbox.mth5_channel_summary_helpers, and one in tf_kernel/dataset.py
    • rename as channel_summary_to_run_summary
    • File Issue in mth5 requesting, as a feature, that a similar method be put into mth5
  • Test channel_scale_factors (can scale individual channels)

  • created issue Add handling of channel_scale_factors to new Processing class #175 to address this

  • Modify run_summary to return actual input/output channel lists based on what is present in channel summary

  • Modify operate_aurora ipynb to use new pipeline tools
    -Made operate_aurora_new.ipynb to test

  • Add start and end times usage to populate_dataset_df so that partial runs are supported

kujaku11 and others added 30 commits February 18, 2022 14:19
Modified process_mth5 by creating process_mth5_runs, nearly a copy of process_mth5_run.
This method will take lists of runs to process and eventually supercede process_mth5_run.

[Issue(s): #31, #118, #80]
Modified process_mth5 to loop over runs and create merged FC object.
Testing ok on decimation level zero.  Now need to add looping over
decimation levels.

[Issue(s): #31, #118, #80]
kkappler added 27 commits May 13, 2022 16:13
…_helpers_new, and change imports accordingly
Modified to allow extract_run_summaries_from_mth5s to accept mth5
objects as well as (already supported) types of pathlib.Path or str
@kkappler
Copy link
Collaborator Author

The new config is now being used in new (duplicates) of all the tests.
The plan is to:

  1. Merge this branch into main
  2. Hop back onto a dev branch and apply the deprecations

@kkappler kkappler merged commit 200d284 into main May 28, 2022
@kkappler kkappler deleted the dev branch August 28, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants