Compare changes using RepliconTick
#602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #602 +/- ##
==========================================
- Coverage 91.93% 91.92% -0.01%
==========================================
Files 58 58
Lines 3321 3320 -1
==========================================
- Hits 3053 3052 -1
Misses 268 268 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
UkoeHB
reviewed
Oct 30, 2025
| // if we detect any insertion on the entity in `collect_changes`. | ||
| if !system_tick.is_newer_than(mutate_info.system_tick, this_run) { | ||
| if *server_tick < mutate_info.server_tick { | ||
| *system_tick = mutate_info.system_tick; |
Collaborator
There was a problem hiding this comment.
Is system_tick still needed?
Contributor
Author
There was a problem hiding this comment.
Yes, we use it for change detection. But since after #553 we now store RepliconTick for prioritization for each entity, we can just use it to check if the entity was already acked.
Shatur
force-pushed
the
rework-lookups
branch
from
1923eeb to
b221bd4
Compare
After #553, we now store a `RepliconTick` per entity. This allows us to simplify acknowledgment by comparing against it instead of comparing by `Tick`.
Contributor
Author
|
Rebased after #601 merge, no code changes. |
UkoeHB
approved these changes
Nov 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #601.
After #553, we now store a
RepliconTickper entity. This allows us to simplify acknowledgment by comparing against it instead of comparing byTick.