Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize ndarray uses in MappedVis #198

Merged
merged 1 commit into from
Sep 16, 2020
Merged

Optimize ndarray uses in MappedVis #198

merged 1 commit into from
Sep 16, 2020

Conversation

loichuder
Copy link
Member

A revised version of #178 to fix #170.

Split useMemo in two in VisProvider (one for ndarray creation, one for slicing).

The useMemo now lives in MappedVis that replaced VisProvider. But it was done.

Simplify unpack(mappedView).flat() by unpacking a flat array directly.

Done with ndarray-ops (scijs/ndarray#32 (comment))

Other tasks were not considered as they depend on cwise which does not seem actively maintained as I pointed out.

@loichuder loichuder requested a review from axelboc September 15, 2020 16:02
axelboc
axelboc approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@axelboc axelboc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well found indeed 👏

@axelboc axelboc mentioned this pull request Sep 16, 2020
Closed
5 tasks
@loichuder loichuder merged commit 56b158b into master Sep 16, 2020
@axelboc axelboc deleted the opti-array-reloaded branch September 24, 2020 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axelboc axelboc axelboc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimise uses of ndarray
2 participants
@loichuder @axelboc