Skip to content

Conversation

@FyreByrd
Copy link
Collaborator

@FyreByrd FyreByrd commented Nov 14, 2025

Upgrade to vite 7 is needed for #903.

Also needed to upgrade to Node 22 in order to upgrade to vite 7.

Test project builds just fine.

I recommend doing a rebase and merge so these two commits are separate from each other.

I did have to rebuild the package-lock.json in order to resolve some peer dependency issues.

Summary by CodeRabbit

  • Chores
    • Updated development tooling and runtime configuration to more recent stable releases.

Note: These are internal developer dependency and runtime updates with no user-facing changes or new features.

This is necessary to use the `base` option in glob imports for #903

I did have to rebuild the package-lock.json in order to resolve some peer dependency issues.
@FyreByrd FyreByrd requested a review from chrisvire November 14, 2025 17:06
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 14, 2025

Walkthrough

Dev tooling and runtime versions updated in project configuration: vite -> 7.2.2, vitest -> 3.2.4, @vitest/ui -> 3.2.4, and Volta node pin -> 22.21.1. No source code or public API changes.

Changes

Cohort / File(s) Summary
Dependency Updates
package.json
Updated devDependency vite from ^6 to ^7.2.2; updated devDependencies vitest and @vitest/ui from ^2 to 3.2.4; updated volta.node from 20.9.0 to 22.21.1.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • Check vite.config.* for breaking changes in Vite v7 and adjust config plugins/options if needed.
  • Verify test configuration and custom reporters/hooks for Vitest v3 compatibility.
  • Review CI/workflow files and local Volta handling for Node 22.21.1 compatibility.
  • Run full test/build locally to surface integration issues.

Poem

🐰 I hopped through package.json with cheer,

Vite and Vitest leapt a major tier,
Node got taller, Volta set to 22,
A rabbit’s nibble and the updates flew! 🥕

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Upgrade/vite' is vague and uses a format that is generic. While it references the Vite upgrade mentioned in the PR objectives, it lacks specificity about the version upgrade (Vite 7) or the Node version update that are the key changes. Consider using a more descriptive title like 'Upgrade Vite to v7 and Node to v22' to clearly convey the main version changes.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch upgrade/vite

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7df8ff4 and 1c63474.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • package.json (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: lint
  • GitHub Check: test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Minimum version that supports vite 7
Copy link
Member

@chrisvire chrisvire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chrisvire chrisvire merged commit 1ccb0ac into main Nov 14, 2025
3 checks passed
@chrisvire chrisvire deleted the upgrade/vite branch November 14, 2025 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants