-
-
Notifications
You must be signed in to change notification settings - Fork 10
Show protection indicators and reasons for entries in completed merges #4036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Replace Paper-based WordBox with Card component using CardHeader and CardContent - Add warning icon with tooltip for protected entries (similar to DropWordCardHeader) - Display protection reasons in multiline tooltip - Add AudioSummary, NoteButton, and FlagButton to header action - Use lightyellow background for protected entries - Import and use existing components from components/WordCard and MergeDuplicates/MergeDupsStep Co-authored-by: imnasnainaec <[email protected]>
- Move tooltip text construction inside conditional block to avoid unnecessary computation - Replace inline styles with sx prop for consistency with MUI patterns - Remove unused theme import Co-authored-by: imnasnainaec <[email protected]>
|
commit 65df42d5a0: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4036 +/- ##
==========================================
- Coverage 74.66% 65.92% -8.74%
==========================================
Files 293 240 -53
Lines 10890 6134 -4756
Branches 1364 779 -585
==========================================
- Hits 8131 4044 -4087
+ Misses 2362 1839 -523
+ Partials 397 251 -146
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
imnasnainaec
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 5 files reviewed, all discussions resolved (waiting on @copilot)
jasonleenaylor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jasonleenaylor reviewed 3 of 5 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @copilot and @imnasnainaec)
imnasnainaec
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@imnasnainaec reviewed 1 of 1 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @copilot)
After completing a merge in Data Cleanup, protected senses show a warning icon with protection reasons, but protected entries do not. Also missing are audio and note summaries at the entry level.
Changes
ProtectedWarningIconfor general useWordBoxto use MUI Card components: Replaced nestedPaperelements withCardHeader+CardContentstructure matchingDropWordCardHeaderpatternProtectedWarningIcon,AudioSummary,NoteButton, andFlagButtonin header actionReviewEntriesCompletedBefore:
After:
All protection data (reasons, audio count, note text) now visible in completed merge view, matching the pattern used during active merging.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.
This change is