Conversation
…for float comparisons
There was a problem hiding this comment.
Pull Request Overview
This pull request removes the dependency on ordered-float and updates float comparison logic to use the native total_cmp method for better integration with Rust’s standard library.
- Replaces OrderedFloat usage with total_cmp in sorting and max-by comparisons in src/lib.rs and src/density_estimation/parzen.rs.
- Removes the ordered-float dependency from Cargo.toml.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/lib.rs | Updated float comparisons in sort and max operations to use total_cmp instead of OrderedFloat. |
| src/density_estimation/parzen.rs | Replaced OrderedFloat usage with total_cmp in sorting and in the logsumexp function. |
| Cargo.toml | Removed the ordered-float dependency. |
sile
changed the title
ordered-float dependency and replace it with total_cmp method for float comparisons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.