update bs-platform to 7.0.1 #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This forced a switch from let-anything to bs-let
Instead of relying on ocaml exceptions, the new implementation switches on the return value of simple get, raising the same exception if None is returned.
|
There's an issue with mutations that have optional args, where I'm looking into it. |
|
The issue is unrelated to the bs-platform@7 update, see andreas/ocaml-graphql-server#181. |
The problem is caused by graphql_ppx_re which is GraphQL spec compliant in that it does not send over the wire optional variables where they were not provided, but the server code expects them to be sent as nulls.
|
Solving the missing variables as part of migrating to bs-platform@7 is required since the newer bs-platform mandates migrating from graphql_ppx to graphql_ppx_re which does not send variables that were not assigned values. |
|
Great work @leeor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This forced a switch from let-anything to bs-let